Skip to content

HostnameVerifier unsafe implementation #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kunalseedoc opened this issue Dec 1, 2016 · 4 comments
Closed

HostnameVerifier unsafe implementation #551

kunalseedoc opened this issue Dec 1, 2016 · 4 comments

Comments

@kunalseedoc
Copy link

HostnameVerifier implementation in parse sdk classes resulting in security exception in play store

"Your app is using an unsafe implementation of HostnameVerifier. Please see this Google Help Center article for details, including the deadline for fixing the vulnerability."

https://support.google.com/faqs/answer/7188426

@danielsanfr
Copy link
Contributor

This is worrying! Someone has to fix this.

@Jawnnypoo
Copy link
Member

Jawnnypoo commented Dec 5, 2016

My guess is that the blame falls on the ParseApacheHttpClient, which should probably just be removed altogether, since there is an OkHttp 3 implementation already in the SDK and just force the dependency. Apache Http was completely removed in API 23, so you are already going to have issues compiling against it.

@Jawnnypoo
Copy link
Member

@kunalseedoc Can you confirm that this originates from Parse and is not possibly coming from another 3rd party library, such as an analytics library?

@rogerhu
Copy link
Contributor

rogerhu commented Mar 9, 2017

Closing unless there is any further issues.

@rogerhu rogerhu closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants