-
-
Notifications
You must be signed in to change notification settings - Fork 736
Remove Apache dependency to allow for higher Android target SDK. #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cd11a64
Remove Apache dependency to allow for higher Android target SDK.
Jawnnypoo 60a9e92
Remove ParseURLConnectionHttpClient in favor of ParseOkHttpClient
Jawnnypoo 02f3169
Add JDK specification to Travis
Jawnnypoo 76e030c
Assure the latest tools are installed
Jawnnypoo 4c979ce
Update to the latest dependencies
Jawnnypoo 0958f63
Update so that the notification is built properly
Jawnnypoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,8 +56,11 @@ interface NotificationCompatImpl { | |
static class NotificationCompatImplBase implements NotificationCompatImpl { | ||
@Override | ||
public Notification build(Builder b) { | ||
Notification result = (Notification) b.mNotification; | ||
result.setLatestEventInfo(b.mContext, b.mContentTitle, b.mContentText, b.mContentIntent); | ||
Notification result = b.mNotification; | ||
NotificationCompat.Builder builder = new NotificationCompat.Builder(b.mContext); | ||
builder.setContentTitle(b.mContentTitle); | ||
builder.setContentText(b.mContentText); | ||
builder.setContentIntent(b.mContentIntent); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this going to work without running builder.build() and returning the result? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch, updated |
||
// translate high priority requests into legacy flag | ||
if (b.mPriority > PRIORITY_DEFAULT) { | ||
result.flags |= FLAG_HIGH_PRIORITY; | ||
|
247 changes: 0 additions & 247 deletions
247
Parse/src/main/java/com/parse/ParseApacheHttpClient.java
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump to 3.3?