feat(title): add proper title to pages #5143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
approved these changes
Mar 15, 2023
azu
left a comment
azu
left a comment
There was a problem hiding this comment.
LGTM.
Node.js
http://localhost:3000/en/
About | Node.js
http://localhost:3000/en/about/
Download | Node.js
http://localhost:3000/en/download/
Documentation | Node.js
http://localhost:3000/en/docs/
Get involved | Node.js
http://localhost:3000/en/get-involved/
News | Node.js
http://localhost:3000/en/blog/
Node v19.8.0 (Current) | Node.js
http://localhost:3000/en/blog/release/v19.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the prior behaviour of showing the frontmatter title as the page title, as it has been done.
It also adds a title for the blog index, and the blog year indexes.
This PR overall fixes a regression.
Closes #5141