All page title is "<title>Node.js</title>"

[azu]

URL:

https://nodejs.org/en/blog/release/v19.8.0

Browser Name:

Chrome

Browser Version:

111.0.5563.64

Operating System:

macOS

How to reproduce the issue:

1. Visit https://nodejs.org/en/blog/release/v19.8.0
2. See <title> and get "Node.js" instead of "Node v19.8.0 (Current)"

Now, Almost page title is "Node.js".

https://nodejs.org/en/
https://nodejs.org/en/about/
https://nodejs.org/en/download/
https://nodejs.org/en/docs/
https://nodejs.org/en/get-involved/
https://nodejs.org/en/blog/

[ovflowd]

This is not a bug. https://github.com/nodejs/nodejs.org/blob/main/components/HtmlHead.tsx#L19, it is expected to all pages to just have Node.js as title. If you want that to change, please submit a feature request.

[azu]

Fmm, Previously Node.js blog use article title.
I think it is regression bug.

nodejs.org/components/HtmlHead.tsx

Line 33 in 3196bc8

<meta property="og:title" content={pageTitle} />

og:title use pageTitle.

https://www.google.co.jp/search?q=site:nodejs.org/en/blog/
https://web.archive.org/web/20230301001519/https://nodejs.org/en/

Previous

• "Node.js": https://web.archive.org/web/20230301001519/https://nodejs.org/en/
• "About | Node.js": https://web.archive.org/web/20230301130646/https://nodejs.org/en/about/
• "Node.js": https://web.archive.org/web/20230307165509/https://nodejs.org/en/blog/
• "Node v14.21.3 (LTS) | Node.js": https://web.archive.org/web/20230307132832/https://nodejs.org/en/blog/release/v14.21.3/

Probably

{pageTitle ? `${pageTitle} | ${siteConfig.title}` : siteConfig.title}

[qnighy]

Original implementation before #4991 seems to have been:

nodejs.org/layouts/partials/html-head.hbs

Line 3 in 5f9862c

<title>{{#if title}}{{ title }} | {{/if}}{{ site.title }}</title>

[ovflowd]

I wouldn't consider that a bug, but indeed a regression. Spot on! Let me reopen this issue :)

[ovflowd]

Working on a PR. Hold tight fellas!

[azu]

@ovflowd Thanks!

Opps, I create same PR
#5142