Skip to content

feat(title): add proper title to pages #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 2 commits into from
Mar 15, 2023
Merged

feat(title): add proper title to pages #5143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984a1c8
feat(title): add proper title to pages
ovflowd Mar 15, 2023
fa6ebc6
Merge branch 'main' into feat/add-title-to-pages
ovflowd Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/HtmlHead.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ const HtmlHead = ({ frontMatter }: HeaderProps) => {
const siteConfig = useSiteConfig();
const { route, basePath } = useRouter();

const pageTitle = frontMatter.title || siteConfig.title;
const canonicalLink = `https://nodejs.org${route}`;

const pageTitle = frontMatter.title
? `${frontMatter.title} | ${siteConfig.title}`
: siteConfig.title;

return (
<Head>
<title>{siteConfig.title}</title>
<title>{pageTitle}</title>

<meta name="theme-color" content={siteConfig.accentColor}></meta>

Expand Down
1 change: 1 addition & 0 deletions pages/en/blog/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
---
layout: blog-index.hbs
title: News
paginate: blog
---
2 changes: 1 addition & 1 deletion scripts/next-data/generatePreBuildFiles.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const publicFeedPath = join(__dirname, '../../public/en/feed');
const createBlogYearFile = year =>
writeFile(
join(blogPath, `year-${year}.md`),
`---\nlayout: blog-index.hbs\npaginate: blog\n---\n`
`---\nlayout: blog-index.hbs\ntitle: News from ${year}\npaginate: blog\n---\n`
);

export const generateBlogYearPages = cachedBlogData =>
Expand Down