Skip to content

Commit c799aea

Browse files
authored
feat(title): add proper title to pages (#5143)
1 parent 2c381b2 commit c799aea

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

components/HtmlHead.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,15 @@ const HtmlHead = ({ frontMatter }: HeaderProps) => {
1111
const siteConfig = useSiteConfig();
1212
const { route, basePath } = useRouter();
1313

14-
const pageTitle = frontMatter.title || siteConfig.title;
1514
const canonicalLink = `https://nodejs.org${route}`;
1615

16+
const pageTitle = frontMatter.title
17+
? `${frontMatter.title} | ${siteConfig.title}`
18+
: siteConfig.title;
19+
1720
return (
1821
<Head>
19-
<title>{siteConfig.title}</title>
22+
<title>{pageTitle}</title>
2023

2124
<meta name="theme-color" content={siteConfig.accentColor}></meta>
2225

pages/en/blog/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
---
22
layout: blog-index.hbs
3+
title: News
34
paginate: blog
45
---

scripts/next-data/generatePreBuildFiles.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const publicFeedPath = join(__dirname, '../../public/en/feed');
2020
const createBlogYearFile = year =>
2121
writeFile(
2222
join(blogPath, `year-${year}.md`),
23-
`---\nlayout: blog-index.hbs\npaginate: blog\n---\n`
23+
`---\nlayout: blog-index.hbs\ntitle: News from ${year}\npaginate: blog\n---\n`
2424
);
2525

2626
export const generateBlogYearPages = cachedBlogData =>

0 commit comments

Comments
 (0)