-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Doc] Fix TBB installation instructions #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@agozillon: FYI |
Nice, thanks for the quick fix! I also forgot to mention in the previous statement I raised that I think the following command may also be a bit outdated for the most recent TBB release:
It appears that the newer release I'm using (tbb-2020.0-lin.tgz) will un-package into a tbb and pstl folder, which means you end up with /opt/intel/tbb/tbb (if the intent of the above commands is to tar extract directly into /opt/intel/tbb). I think the command could perhaps be:
That is if the intent was to end up with just an /opt/intel/tbb like the current symbolic link commands seem to expect. Or alternatively I suppose the symbolic link commands could just be updated to be prefixed with /opt/intel/tbb/tbb/ rather than the current /opt/intel/tbb/ |
@agozillon The file has been adopted for changes in TBB 2020. |
Awesome, LGTM thanks for fixing this and sorry for bothering you with it! |
Signed-off-by: Vladimir Lazarev <[email protected]>
9f806f0
to
bf463a1
Compare
This is workaround to fix crash, which caused by using `dyn_cast` on a `nullptr`, as the result of translation of `Entity` operand of `DebugImportedEntity`, because this operand is `DebugInfoNone`. Original commit: KhronosGroup/SPIRV-LLVM-Translator@ff7d062
* sycl: (625 commits) [SYCL] Fix post-commit build failure (intel#3578) [SYCL] Add support for set(get)_specialization_constant (intel#3501) [SYCL] Do not allow template instantiation to create null attributes. (intel#3575) [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552) [SYCL] Raise bit_cast to SYCL namespace (intel#3524) [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547) [SYCL] Fix warnings on clang-based build (intel#3570) Revert "Align tests with the codegen changes" Disable SPV_INTEL_memory_access_aliasing extension Fix build issues after applying translator patches [PassManager][PhaseOrdering] lower expects before running simplifyCFG Exclude spirv.hpp for clang-format Fix llvm-spirv crash when count of Fortran metadata variables is an array Fix transTypeComposite bug (intel#964) Fix incorrect translation of FPGA decoration on arrays (intel#983) Tolerate more inputs during alias.scope/noalias MD translation (intel#994) Update for LLVM iterator change Fix crash at translation of Entity of DebugImportedEntity (intel#951) Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL) Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported ...
The issues has been reported in #823 (comment)