Skip to content

[SYCL][Doc] Fix TBB installation instructions #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

vladimirlaz
Copy link
Contributor

The issues has been reported in #823 (comment)

@bader bader changed the title [SYCL] Fix TBB installation instructions [SYCL][Doc] Fix TBB installation instructions Dec 19, 2019
@AlexeySachkov
Copy link
Contributor

@agozillon: FYI

@agozillon
Copy link
Contributor

Nice, thanks for the quick fix!

I also forgot to mention in the previous statement I raised that I think the following command may also be a bit outdated for the most recent TBB release:

mkdir -p /opt/intel/tbb
cd /opt/intel/tbb
tar -zxvf tbb2019_<version>oss_lin.tgz

It appears that the newer release I'm using (tbb-2020.0-lin.tgz) will un-package into a tbb and pstl folder, which means you end up with /opt/intel/tbb/tbb (if the intent of the above commands is to tar extract directly into /opt/intel/tbb).

I think the command could perhaps be:

mkdir -p /opt/intel/
cd /opt/intel/
tar -zxvf tbb2019_<version>oss_lin.tgz

That is if the intent was to end up with just an /opt/intel/tbb like the current symbolic link commands seem to expect. Or alternatively I suppose the symbolic link commands could just be updated to be prefixed with /opt/intel/tbb/tbb/ rather than the current /opt/intel/tbb/

@vladimirlaz
Copy link
Contributor Author

@agozillon The file has been adopted for changes in TBB 2020.

@bader bader self-assigned this Dec 20, 2019
@agozillon
Copy link
Contributor

@agozillon The file has been adopted for changes in TBB 2020.

Awesome, LGTM thanks for fixing this and sorry for bothering you with it!

@vladimirlaz vladimirlaz requested a review from bader December 24, 2019 11:39
bader
bader previously approved these changes Dec 24, 2019
@bader bader merged commit 02c426c into intel:sycl Dec 24, 2019
@vladimirlaz vladimirlaz deleted the fix_tbb_install_guide branch April 2, 2020 13:55
vladimirlaz pushed a commit to vladimirlaz/llvm that referenced this pull request Apr 19, 2021
This is workaround to fix crash, which caused by using `dyn_cast` on a `nullptr`,
as the result of translation of `Entity` operand of `DebugImportedEntity`, because
this operand is `DebugInfoNone`.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@ff7d062
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 20, 2021
* sycl: (625 commits)
  [SYCL] Fix post-commit build failure (intel#3578)
  [SYCL] Add support for set(get)_specialization_constant (intel#3501)
  [SYCL] Do not allow template instantiation to create null attributes. (intel#3575)
  [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552)
  [SYCL] Raise bit_cast to SYCL namespace (intel#3524)
  [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547)
  [SYCL] Fix warnings on clang-based build (intel#3570)
  Revert "Align tests with the codegen changes"
  Disable SPV_INTEL_memory_access_aliasing extension
  Fix build issues after applying translator patches
  [PassManager][PhaseOrdering] lower expects before running simplifyCFG
  Exclude spirv.hpp for clang-format
  Fix llvm-spirv crash when count of Fortran metadata variables is an array
  Fix transTypeComposite bug (intel#964)
  Fix incorrect translation of FPGA decoration on arrays (intel#983)
  Tolerate more inputs during alias.scope/noalias MD translation (intel#994)
  Update for LLVM iterator change
  Fix crash at translation of Entity of DebugImportedEntity (intel#951)
  Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL)
  Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants