[SYCL] Fix warnings on clang-based build #3570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvchupin
requested review from
AaronBallman,
AlexeySachkov,
AlexeySotkin,
elizabethandrews,
premanandrao and
a team
as code owners
pvchupin
changed the title
* CompilerInvocation.cpp: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses] * clang/lib/Sema/SemaSYCL.cpp: error: private field 'Footer' is not used [-Werror,-Wunused-private-field] * SPIRVUtil.cpp: error: private field 'RetTy' is not used [-Werror,-Wunused-private-field] * os_util.cpp: comparison of integers of different signs: 'int' and 'const unsigned long long' [-Werror,-Wsign-compare] Signed-off-by: Pavel V Chupin <[email protected]>
bader
reviewed
Apr 17, 2021
llvm-spirv/lib/SPIRV/SPIRVUtil.cpp
Outdated
| @@ -1720,6 +1720,9 @@ class OpenCLStdToSPIRVFriendlyIRMangleInfo : public BuiltinFuncMangleInfo { | |||
| private: | |||
| OCLExtOpKind ExtOpId; | |||
| ArrayRef<Type *> ArgTys; | |||
| #ifdef __clang__ | |||
| [[maybe_unused]] | |||
| #endif | |||
There was a problem hiding this comment.
This change should be committed to https://github.com/KhronosGroup/SPIRV-LLVM-Translator/.
There was a problem hiding this comment.
@AlexeySotkin, @AlexeySachkov, can you take care of this please?
There was a problem hiding this comment.
I gave that a try: KhronosGroup/SPIRV-LLVM-Translator#1004
pvchupin
changed the title
Co-authored-by: Aaron Ballman <[email protected]>
LLVM_ATTRIBUTE_UNUSED produces warning/error with GCC
It's appeared that LLVM_ATTRIBUTE_UNUSED is not portable as well. Producing warning/error with G++. |
AaronBallman
approved these changes
Apr 18, 2021
|
Please fix the description. SPIRVUtil.cpp changes are no longer part of this PR. |
againull
approved these changes
Apr 19, 2021
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 20, 2021
* sycl: (625 commits) [SYCL] Fix post-commit build failure (intel#3578) [SYCL] Add support for set(get)_specialization_constant (intel#3501) [SYCL] Do not allow template instantiation to create null attributes. (intel#3575) [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552) [SYCL] Raise bit_cast to SYCL namespace (intel#3524) [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547) [SYCL] Fix warnings on clang-based build (intel#3570) Revert "Align tests with the codegen changes" Disable SPV_INTEL_memory_access_aliasing extension Fix build issues after applying translator patches [PassManager][PhaseOrdering] lower expects before running simplifyCFG Exclude spirv.hpp for clang-format Fix llvm-spirv crash when count of Fortran metadata variables is an array Fix transTypeComposite bug (intel#964) Fix incorrect translation of FPGA decoration on arrays (intel#983) Tolerate more inputs during alias.scope/noalias MD translation (intel#994) Update for LLVM iterator change Fix crash at translation of Entity of DebugImportedEntity (intel#951) Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL) Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[-Werror,-Wlogical-op-parentheses]
[-Werror,-Wunused-private-field]
'const unsigned long long' [-Werror,-Wsign-compare]
Signed-off-by: Pavel V Chupin [email protected]