Skip to content

[SYCL] Raise bit_cast to SYCL namespace #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 20, 2021

Conversation

cperkinsintel
Copy link
Contributor

SYCL2020 has bit_cast provided in SYCL namespace now. Moved it and updated tests and internal references

Signed-off-by: Chris Perkins [email protected]

…dated tests and internal references

Signed-off-by: Chris Perkins <[email protected]>
@cperkinsintel
Copy link
Contributor Author

I believe the Jenkins Precommit stage is failing because there is a copy of the bit_cast test over there. I have a draft PR ( intel/llvm-test-suite#228 ) that updates the bit_cast test on llvm-test-suite. It should be able to pass once this PR is merged.

bader
bader previously approved these changes Apr 11, 2021
Signed-off-by: Chris Perkins <[email protected]>
@romanovvlad
Copy link
Contributor

failing because there is a copy of the ``

Suggest having sycl::detail::bit_cast available by having using bit_cast = sycl::bit_cast in the detail namespace.

…tail namespace to help tests pass and avoid any near term backwards compatibility issues.

Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
@bader bader changed the title [SYCL] raise bit_cast to SYCL namespace [SYCL] Raise bit_cast to SYCL namespace Apr 14, 2021
@cperkinsintel
Copy link
Contributor Author

ping to code owners. This should be ready.

@pvchupin
Copy link
Contributor

That's @AlexeySachkov

@bader bader merged commit d4b66bd into intel:sycl Apr 20, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 20, 2021
* sycl: (625 commits)
  [SYCL] Fix post-commit build failure (intel#3578)
  [SYCL] Add support for set(get)_specialization_constant (intel#3501)
  [SYCL] Do not allow template instantiation to create null attributes. (intel#3575)
  [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552)
  [SYCL] Raise bit_cast to SYCL namespace (intel#3524)
  [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547)
  [SYCL] Fix warnings on clang-based build (intel#3570)
  Revert "Align tests with the codegen changes"
  Disable SPV_INTEL_memory_access_aliasing extension
  Fix build issues after applying translator patches
  [PassManager][PhaseOrdering] lower expects before running simplifyCFG
  Exclude spirv.hpp for clang-format
  Fix llvm-spirv crash when count of Fortran metadata variables is an array
  Fix transTypeComposite bug (intel#964)
  Fix incorrect translation of FPGA decoration on arrays (intel#983)
  Tolerate more inputs during alias.scope/noalias MD translation (intel#994)
  Update for LLVM iterator change
  Fix crash at translation of Entity of DebugImportedEntity (intel#951)
  Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL)
  Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants