[SYCL] Add support for set(get)_specialization_constant #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2021 10:38
romanovvlad
reviewed
Apr 8, 2021
romanovvlad
requested changes
Apr 12, 2021
Co-authored-by: Romanov Vlad <[email protected]>
… into get_set_spec_constants * 'get_set_spec_constants' of github.com:alexbatashev/llvm: Update sycl/source/detail/kernel_bundle_impl.hpp
romanovvlad
requested changes
Apr 12, 2021
sycl/test/on-device/basic_tests/specialization_constants/host_apis.cpp
Outdated
Show resolved
Hide resolved
sycl/test/on-device/basic_tests/specialization_constants/host_apis.cpp
Outdated
Show resolved
Hide resolved
sycl/test/on-device/basic_tests/specialization_constants/host_apis.cpp
Outdated
Show resolved
Hide resolved
added 2 commits
April 13, 2021 09:28
mlychkov
reviewed
Apr 13, 2021
romanovvlad
approved these changes
Apr 13, 2021
|
@kbobrovs friendly ping |
kbobrovs
reviewed
Apr 14, 2021
kbobrovs
approved these changes
Apr 20, 2021
|
@alexbatashev, could you give a description for this 400+ lines patch? |
Done |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 20, 2021
* sycl: (625 commits) [SYCL] Fix post-commit build failure (intel#3578) [SYCL] Add support for set(get)_specialization_constant (intel#3501) [SYCL] Do not allow template instantiation to create null attributes. (intel#3575) [SYCL][PI][L0] Close and submit batch immediately when Queue is empty. (intel#3552) [SYCL] Raise bit_cast to SYCL namespace (intel#3524) [ESIMD] Always preserve -vc-codegen option for ESIMD kernels (intel#3547) [SYCL] Fix warnings on clang-based build (intel#3570) Revert "Align tests with the codegen changes" Disable SPV_INTEL_memory_access_aliasing extension Fix build issues after applying translator patches [PassManager][PhaseOrdering] lower expects before running simplifyCFG Exclude spirv.hpp for clang-format Fix llvm-spirv crash when count of Fortran metadata variables is an array Fix transTypeComposite bug (intel#964) Fix incorrect translation of FPGA decoration on arrays (intel#983) Tolerate more inputs during alias.scope/noalias MD translation (intel#994) Update for LLVM iterator change Fix crash at translation of Entity of DebugImportedEntity (intel#951) Add HandleLLVMOptions to main CMakeLists.txt to propagate configuration flags. In particular, this enables Multi-threaded option in MSVC (instead of Multi-threaded DLL) Fix uninitialized variables warnings These warnings come into place when HandleLLVMOptions is imported ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces Spec Constant Name to Spec ID mapping for
device_images and implementskernel_bundle::set(get)_specialization_constant()andhandler::set(get)_specialization_constantmember functions. See 4.9.5.2. Setting and getting the value of a specialization constant.