3.4 patch: Remove capacity bounding on WebSocketWriterPipeline - cherry pick of #199 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
Closed
sungam3r
approved these changes
Oct 26, 2020
Member
Author
|
Version 3.4.1 has been published with this fix. Version 3.4.x is now in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #250 via PR #199 into
master(3.4) branch for 3.4.1 fix.Already fixed in 3.5
Note: do not use "squash and merge" to merge this issue.