Replace Appveyor with GitHub Actions #391

Shane32 · 2020-09-16T14:56:46Z

This PR adds GitHub Actions (workflows) for the following purposes:

Test PRs on windows and ubuntu with .NET 2.2 and .NET 3.1
Create nuget packages when a PR is merged (or any other commit to master or develop) and publish them to the GitHub Packages repository. Versions have the prefix specified in the build props file, with a suffix that increments starting a little above 1000.
Publish nuget packages to Nuget when a release is issued, using the exact version number specified in the "tag" of the release.

This does not publish to myget. This could be enabled by changing the build.yml file a little.

In order to have this code publish to Nuget, the API key for Nuget must be loaded into a NUGET_AUTH_TOKEN GitHub secret. See Settings > Secrets. Secrets cannot be read by workflows in forked repositories, so they are secure. Who holds the proper Nuget account? They will need to generate a new API key and punch it in.

I've tested as much as I can at this point. I'd prefer to merge, issue a release, and review the artifacts generated. It will not publish to nuget because it will not have an API key. If all is well, then add the NUGET_AUTH_TOKEN and delete and reissue the release.

Shane32 · 2020-09-17T04:03:44Z

Sourcelink should be working now. Based on:

https://devblogs.microsoft.com/nuget/introducing-source-code-link-for-nuget-packages/

Also tested generated packages with Nuget Package Explorer

sungam3r · 2020-09-17T10:19:21Z

Thank. I'll put this PR aside for now to finish other things. Now there is no urgent need to build the release. In parallel, I will read the documentation on github actions and appveyor. As a result, I would like to choose the simplest and most understandable solution with a minimum of scripts.

Shane32 · 2020-09-17T14:07:39Z

with a minimum of scripts

I agree.

We can delete these files if we remove appveyor:

appveyor.yml
build.cake
build.ps1
build.sh
gitversion.yml
tools/packages.config

most understandable

I agree.

GitHub Actions is only a single script for a single action. We have three actions, so there are three independent scripts.
Personally I think this is part of what makes GitHub Action scripts easier to understand.

sungam3r · 2020-09-17T14:52:10Z

@Shane32 I propose to change version template for GraphQL.NET preview packages. Now it is x.y.z.b where b is a github build number. It is not semver compatible version. Let's change it to x.y.z-preview.b like MS does.

Directory.Build.props

Shane32 · 2020-09-17T14:56:19Z

Done. Start at 1 or 1001?

sungam3r · 2020-09-17T15:28:41Z

I prefer 1. But I talked about GraphQL.NET, not server project. By the way, how to reset github build number?

Shane32 · 2020-09-17T15:30:26Z

Would we not want a consistent build process for all the projects?

We can reset the number by renaming the yml file, as noted in the comment in the yml file.

sungam3r · 2020-09-17T21:06:05Z

Would we not want a consistent build process for all the projects?

Sure. I just drew attention to the fact that it is worth changing the counter in the already committed code in graphql-net.

Directory.Build.props

sungam3r · 2020-10-26T13:09:31Z

tests/Transports.Subscriptions.WebSockets.Tests/TestStartup.cs

                .AddWebSockets();
+            services.AddLogging(builder =>
+            {
+                // prevent writing errors to Console.Error during tests (required for testing on ubuntu)


Wow! Does this cause the tests to fail?

What about allow to write logs on Windows?

if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) { // Do something }

I can’t remember anymore. Maybe it just caused a bunch of extra output. I think it caused a failure though, without this change. I did write “required”...

...s/Transports.Subscriptions.WebSockets.Tests/Transports.Subscriptions.WebSockets.Tests.csproj

Co-authored-by: Ivan Maximov <[email protected]>

.github/labeler.yml

.github/workflows/build.yml

Directory.Build.props

Co-authored-by: Ivan Maximov <[email protected]>

sungam3r · 2020-10-26T14:16:31Z

Thanks for this PR. One question left : VersionSuffix. I still don't understand why this is needed.
I'm OK with Deterministic=true event if it is true by default.

Shane32 · 2020-10-26T14:52:56Z

It's not needed, per se. It just ensures that any local build will not have a "real" version number. Actually, nevermind. Since the default prefix has "preview" in it already, that should be covered. I'll remove that.

Co-authored-by: Ivan Maximov <[email protected]>

sungam3r

The last suggestion is to move <VersionPrefix>4.1.0-preview</VersionPrefix> on the first line inside props section.

sungam3r · 2020-10-26T17:00:40Z

By the way, here I configured branches https://github.com/graphql-dotnet/server/settings/branches for both master and develop but in GraphQL.NET I can see only master rule https://github.com/graphql-dotnet/graphql-dotnet/settings/branches.

Shane32 self-assigned this Sep 16, 2020

Shane32 force-pushed the github-packages branch from 35796f7 to 133ec90 Compare September 16, 2020 18:36

Add GitHub workflows

3459f3f

Shane32 force-pushed the github-packages branch from 53eaa0a to 3459f3f Compare September 16, 2020 19:17

Run tests for any PR, not just changes to src

6c49f2b

Shane32 requested review from pekkah and sungam3r September 16, 2020 19:31

Shane32 marked this pull request as ready for review September 16, 2020 19:31

Shane32 added 2 commits September 16, 2020 15:34

Always build artifacts; why not?

e78e6eb

Update TestStartup.cs

3a2089d

Shane32 mentioned this pull request Sep 16, 2020

When 3.5 and/or 4.0 version would be released? #389

Closed

Shane32 added 5 commits September 16, 2020 22:44

Add SourceLink support

621afbd

Update Directory.Build.props

4c9ac4b

Test build

9fc40a2

Update build.yml

1cb0935

Update publish.yml

27efd78

Fix naming of xml files

bcf0558

sungam3r added the CI CI configuration issue or pull request label Sep 17, 2020

Shane32 commented Sep 17, 2020

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Update Directory.Build.props

2c7f88e

Update build.yml

bc15956

Update workflow files

309f4fe

sungam3r reviewed Oct 26, 2020

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

sungam3r reviewed Oct 26, 2020

View reviewed changes

...s/Transports.Subscriptions.WebSockets.Tests/Transports.Subscriptions.WebSockets.Tests.csproj Show resolved Hide resolved

Shane32 and others added 5 commits October 26, 2020 09:17

Apply suggestions from code review

f3ac594

Co-authored-by: Ivan Maximov <[email protected]>

Update .github/workflows/build.yml

d278168

Co-authored-by: Ivan Maximov <[email protected]>

Update .github/workflows/publish.yml

fcd51f1

Update .github/workflows/publish.yml

da5ef7a

Update .github/workflows/publish.yml

04ee79c

Co-authored-by: Ivan Maximov <[email protected]>

Shane32 commented Oct 26, 2020

View reviewed changes

.github/labeler.yml Outdated Show resolved Hide resolved

Shane32 commented Oct 26, 2020

View reviewed changes

.github/labeler.yml Outdated Show resolved Hide resolved

Shane32 commented Oct 26, 2020

View reviewed changes

.github/labeler.yml Outdated Show resolved Hide resolved

Update labeler

a6d93c9

github-actions bot added the performance label Oct 26, 2020

Shane32 requested a review from sungam3r October 26, 2020 13:45

sungam3r reviewed Oct 26, 2020

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

sungam3r reviewed Oct 26, 2020

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

sungam3r reviewed Oct 26, 2020

View reviewed changes

Directory.Build.props Outdated Show resolved Hide resolved

Shane32 and others added 3 commits October 26, 2020 10:06

Update .github/workflows/build.yml

76d3a4a

Co-authored-by: Ivan Maximov <[email protected]>

Update .github/workflows/build.yml

732e7b0

Co-authored-by: Ivan Maximov <[email protected]>

Update Directory.Build.props

816299b

Co-authored-by: Ivan Maximov <[email protected]>

Update Directory.Build.props

3d5c36f

Co-authored-by: Ivan Maximov <[email protected]>

sungam3r approved these changes Oct 26, 2020

View reviewed changes

Update Directory.Build.props

6334e2c

Shane32 merged commit 31d3858 into develop Oct 26, 2020

Shane32 deleted the github-packages branch October 26, 2020 16:57

Shane32 mentioned this pull request Oct 26, 2020

Move to master branch #417

Closed

Shane32 added a commit that referenced this pull request Oct 26, 2020

Replace Appveyor with GitHub Actions (see #391)

9d45266

Replace Appveyor with GitHub Actions #391

Replace Appveyor with GitHub Actions #391

Uh oh!

Conversation

Shane32 commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shane32 commented Sep 17, 2020

Uh oh!

sungam3r commented Sep 17, 2020

Uh oh!

Shane32 commented Sep 17, 2020

Uh oh!

sungam3r commented Sep 17, 2020

Uh oh!

Uh oh!

Shane32 commented Sep 17, 2020

Uh oh!

sungam3r commented Sep 17, 2020

Uh oh!

Shane32 commented Sep 17, 2020

Uh oh!

sungam3r commented Sep 17, 2020

Uh oh!

Uh oh!

sungam3r Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

sungam3r Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

Shane32 Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

sungam3r Oct 26, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sungam3r commented Oct 26, 2020

Uh oh!

Shane32 commented Oct 26, 2020

Uh oh!

sungam3r left a comment

Choose a reason for hiding this comment

Uh oh!

sungam3r commented Oct 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shane32 commented Sep 16, 2020 •

edited

Loading