Use MVC JsonSerializerSettings & Indent JSON in Development #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he MVC built in JsonSerializerSettings.
Contributor
Author
|
This PR also helps with graphql-dotnet/graphql-dotnet#662 in that MVC sets |
joemcbride
approved these changes
Jun 6, 2018
Member
joemcbride
left a comment
joemcbride
left a comment
There was a problem hiding this comment.
These look fine to me. Any objections @pekkah ?
pekkah
added a commit
that referenced
this pull request
Jun 6, 2018
…118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115)" This reverts commit 00a67a1.
Contributor
|
Can you reopen against develop branch |
Contributor
Author
|
Moved to #121 |
pobisw
pushed a commit
to pobisw/server
that referenced
this pull request
Dec 29, 2018
…raphql-dotnet#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115)" This reverts commit 00a67a1.
pobisw
pushed a commit
to pobisw/server
that referenced
this pull request
Dec 29, 2018
…raphql-dotnet#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115)" This reverts commit 00a67a1.
pekkah
pushed a commit
that referenced
this pull request
Feb 14, 2019
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
rose-a
added a commit
to rose-a/server
that referenced
this pull request
Mar 23, 2020
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (graphql-dotnet#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
Shane32
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JsonSerializerSettingsis available in MVC viaIOptions<T>that is very easy to configure via.AddMvcCore(...).AddJsonOptions(...). So perhaps we should use it.The second part of this PR is to indent the JSON when running in development mode for better readability.