Remove capacity bounding on WebSocketWriterPipeline #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he MVC built in JsonSerializerSettings. (graphql-dotnet#115)
…e to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117) This reverts commit a4993c8.
…raphql-dotnet#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115)" This reverts commit 00a67a1.
Release 3.1
Release 3.2
Release 3.3.0
Release 3.4
rose-a
added a commit
to haprotec/graphql-client
that referenced
this pull request
Jan 28, 2019
deinok
pushed a commit
to graphql-dotnet/graphql-client
that referenced
this pull request
Jan 29, 2019
* add StringEnumConverter to JsonSerializerSettings * fix dependencies * change version * fix version * fix CloseAsync * lock dispose * implement external exception handling for subscription streams * fix doc comment * add back-off delay for automatic reconnects * create GraphQLHttpWebSocket class * get single socket working * fix subscription test, cleanup code * more code cleanup * add test CanConnectMultipleSubscriptionsSimultaneously * dynamically find free ports for integration test * add WebSocketExceptionHandler to clientOptions * move reconnect-logic into subscriptions * move external exception handler declaration to CreateSubscriptionStream overloads * fix exception on disposing disconnected subscription * fix tests, add console app for testing reconnect after server restart * Update GraphQL.Client.Tests.csproj * Nullable check (#86) * nonnullable * fix some things * other fix * netstandard2.0 * Update README.md * create "queue" for requests so that only one send operation is performed at a time * fix websockets on win 7 * remove websockets4net dependency * Update root.props * Update config.yml * IsTestProject * Benchmar * benchmark * Update GraphQLLocation.cs * new Spec * fix suff for dotnet core 3.0 * check response for 'null' in where clause * add obsolete parameterless constructor to GraphQLRequest * add debug output in websocket receive * reuse observables for identical requests * store changes to consoleapp * fix StackOverflowException in GraphQLRequest.GetHashCode() * fix receiving long messages via websocket * add obsolete constructor * make ReceiveResultStream observable Hot * fix multiple subscriptions by using subject in GraphQLHttpWebSocket * fix overlapping subscriptions * fix subscription test to work arround graphql-dotnet/server#199 * add an observable which publishes all websocket exceptions * fix OnNext calls of exceptionSubject * fix GraphQLHttpClient(Uri endPoint, GraphQLHttpClientOptions options) constructor * test requests via websockets * bump pre-release version
deinok
pushed a commit
to graphql-dotnet/graphql-client
that referenced
this pull request
Feb 11, 2019
* add StringEnumConverter to JsonSerializerSettings * fix dependencies * change version * fix version * fix CloseAsync * lock dispose * implement external exception handling for subscription streams * fix doc comment * add back-off delay for automatic reconnects * create GraphQLHttpWebSocket class * get single socket working * fix subscription test, cleanup code * more code cleanup * add test CanConnectMultipleSubscriptionsSimultaneously * dynamically find free ports for integration test * add WebSocketExceptionHandler to clientOptions * move reconnect-logic into subscriptions * move external exception handler declaration to CreateSubscriptionStream overloads * fix exception on disposing disconnected subscription * fix tests, add console app for testing reconnect after server restart * Update GraphQL.Client.Tests.csproj * Nullable check (#86) * nonnullable * fix some things * other fix * netstandard2.0 * Update README.md * create "queue" for requests so that only one send operation is performed at a time * fix websockets on win 7 * remove websockets4net dependency * Update root.props * Update config.yml * IsTestProject * Benchmar * benchmark * Update GraphQLLocation.cs * new Spec * fix suff for dotnet core 3.0 * check response for 'null' in where clause * add obsolete parameterless constructor to GraphQLRequest * add debug output in websocket receive * reuse observables for identical requests * store changes to consoleapp * fix StackOverflowException in GraphQLRequest.GetHashCode() * fix receiving long messages via websocket * add obsolete constructor * make ReceiveResultStream observable Hot * fix multiple subscriptions by using subject in GraphQLHttpWebSocket * fix overlapping subscriptions * fix subscription test to work arround graphql-dotnet/server#199 * add an observable which publishes all websocket exceptions * fix OnNext calls of exceptionSubject * fix GraphQLHttpClient(Uri endPoint, GraphQLHttpClientOptions options) constructor * test requests via websockets * bump pre-release version * fix initializing websocket when multiple threads create a subscription concurrently
rose-a
deleted the
remove-capacity-bounding-on-websocket-writer-pipeline
branch
Closed
deinok
pushed a commit
to graphql-dotnet/graphql-client
that referenced
this pull request
Mar 7, 2019
* add StringEnumConverter to JsonSerializerSettings * fix dependencies * change version * fix version * fix CloseAsync * lock dispose * implement external exception handling for subscription streams * fix doc comment * add back-off delay for automatic reconnects * create GraphQLHttpWebSocket class * get single socket working * fix subscription test, cleanup code * more code cleanup * add test CanConnectMultipleSubscriptionsSimultaneously * dynamically find free ports for integration test * add WebSocketExceptionHandler to clientOptions * move reconnect-logic into subscriptions * move external exception handler declaration to CreateSubscriptionStream overloads * fix exception on disposing disconnected subscription * fix tests, add console app for testing reconnect after server restart * Update GraphQL.Client.Tests.csproj * Nullable check (#86) * nonnullable * fix some things * other fix * netstandard2.0 * Update README.md * create "queue" for requests so that only one send operation is performed at a time * fix websockets on win 7 * remove websockets4net dependency * Update root.props * Update config.yml * IsTestProject * Benchmar * benchmark * Update GraphQLLocation.cs * new Spec * fix suff for dotnet core 3.0 * check response for 'null' in where clause * add obsolete parameterless constructor to GraphQLRequest * add debug output in websocket receive * reuse observables for identical requests * store changes to consoleapp * fix StackOverflowException in GraphQLRequest.GetHashCode() * fix receiving long messages via websocket * add obsolete constructor * make ReceiveResultStream observable Hot * fix multiple subscriptions by using subject in GraphQLHttpWebSocket * fix overlapping subscriptions * fix subscription test to work arround graphql-dotnet/server#199 * add an observable which publishes all websocket exceptions * fix OnNext calls of exceptionSubject * fix GraphQLHttpClient(Uri endPoint, GraphQLHttpClientOptions options) constructor * test requests via websockets * bump pre-release version * use JsonSerializerSettings from options in websocket requests * fix query errors via websocket * fix sequence termination and error handling in websocket streams
rose-a
added a commit
to rose-a/server
that referenced
this pull request
Mar 23, 2020
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (graphql-dotnet#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" (graphql-dotnet#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (graphql-dotnet#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (graphql-dotnet#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
Shane32
pushed a commit
that referenced
this pull request
Aug 31, 2020
* Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115) * Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116) * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117) This reverts commit a4993c8. * Revert "Use MVC JsonSerializerSettings & Indent JSON in Development" (#118) * Revert "Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" (#117)" This reverts commit 64a4658. * Revert "Add ComplexityConfiguration, EnableMetrics, SetFieldMiddleware to GraphQLHttpOptions (#116)" This reverts commit a4993c8. * Revert "Initialize the DocumentWriter so it indents in development and uses the MVC built in JsonSerializerSettings. (#115)" This reverts commit 00a67a1. * remove BoundedCapacity (defaults to Unbounded)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capacity bounding prevents subscription updates to reach their target in a single WebSocket scenario where multiple subscriptions push an update simultaneously, since following update messages are discarded as long as the first message is being sent.