Release 3.3.0 #188
Merged
Release 3.3.0 #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracing pane is disabled by default in GraphQL Playground. This PR turns it on according to the [documentation](https://github.com/prisma/graphql-playground). I've tried using Chrome's override feature to add this code in the HTML but it doesn't seem to work, I'm hoping someone can point the way. See also Apollo Tracing graphql-dotnet/graphql-dotnet#381
* Add GraphQL.Server.Authorization.AspNetCore NuGet package * Rename file for consistency. * Reference ASP.NET Core 2.0 * Default metadata to null instead of creating new lists. * Use IHttpContextAccessor instead of IProvideClaimsPrincipal * TryAdd IHttpContextAccessor
Use IDocumentWriter.WriteAsync() to write to response stream
#177) * Fix the issue when the client prematurely closes and the server cannot complete the websocket reader pipeline * Fix the issue when the client prematurely closed. Add a try/finally block for cases when CloseAsync fails because socket is in Aborted state
* Updated: websocket implementation to support documentwriter. * Changed: NotImplementedException to NotSupportedException Co-Authored-By: DSilence <[email protected]> * Fixed some code review issues. * Implemented unit tests for payloads of varying size
Contributor
|
Thanks @pekkah for starting the review process. Can't wait for proper auth support and tracing support in the playground! |
The list of UI Middlewares to add was 1 long list so wasn't easy to read, made it fall to new line so it's readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.