Skip to content

Fix ephemeral runner deletion #34447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 20, 2025
Merged

Fix ephemeral runner deletion #34447

merged 13 commits into from
May 20, 2025

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented May 13, 2025 •
edited
Loading

  • repository deletion, delete ephemeral runners with active tasks as well skips regular cleanup
  • user deletion, delete ephemeral runners with active tasks as well skips regular cleanup
  • delete ephemeral runners once status changes to done
  • You no longer see used ephemeral runners after the task is done
    • if you see one the cron job takes care of it

@ChristopherHX
Fix ephemeral runner deletion
b3b8eb5 
* repository deletion, deletes active tasks as well
* user deletion, implicitly deletes active tasks as well
* delete ephemeral runners once status changes to done
@ChristopherHX
fix fmt
3adc64b
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 13, 2025
@ChristopherHX ChristopherHX added the backport/v1.24 This PR should be backported to Gitea 1.24 label May 13, 2025
@ChristopherHX
Copy link
Contributor Author

ChristopherHX commented May 13, 2025 •
edited
Loading

@NorthRealm Thank you for you workflow run deletion PR, without yours I might have not noticed these defects in my ephemeral runner implementation.

I also noticed you can delete running workflows / tasks by deleting a User / Repository. If the ephemeral runner is shared to this repository this leaks....

Since the database is frozen for 1.24, I think this is the best that could be backported to 1.24.

ChristopherHX
ChristopherHX commented May 13, 2025
View reviewed changes
@ChristopherHX ChristopherHX marked this pull request as ready for review May 13, 2025 19:12
lunny
lunny reviewed May 13, 2025
View reviewed changes
@ChristopherHX ChristopherHX mentioned this pull request May 14, 2025
Closed
lunny
lunny reviewed May 18, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2025
@techknowlogick techknowlogick enabled auto-merge (squash) May 20, 2025 15:16
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2025
@techknowlogick techknowlogick added the topic/gitea-actions related to the actions of Gitea label May 20, 2025
@techknowlogick techknowlogick merged commit 73f640f into go-gitea:main May 20, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone May 20, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 20, 2025
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.24. @ChristopherHX, please send one manually. 🍵

go run ./contrib/backport 34447
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label May 21, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 21, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
2549ad6 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix ephemeral runner deletion (go-gitea#34447)
  ui: add a default tab on repo header when migrating (go-gitea#34503)
  Use run-name and evaluate workflow variables (go-gitea#34301)
  feat(api): add date range filtering to commit retrieval endpoints (go-gitea#34497)
  Export repo's manual merge settings (go-gitea#34502)
@NorthRealm NorthRealm mentioned this pull request May 21, 2025
Merged
@lunny lunny added the backport/done All backports for this PR have been created label May 21, 2025
techknowlogick pushed a commit that referenced this pull request May 21, 2025
@NorthRealm
Fix ephemeral runner deletion (#34447) (#34513)
038990e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristopherHX @GiteaBot @lunny @wxiaoguang @techknowlogick