Skip to content

Refactor dropdown ellipsis #34123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 5, 2025
Merged

Refactor dropdown ellipsis #34123

merged 7 commits into from
Apr 5, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 4, 2025 •
edited
Loading

Remove legacy truncated-item-container and truncated-item-name. Now only using ellipsis-text-items is enough.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 4, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Apr 4, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 4, 2025 •
edited
Loading

image

image

image

image

image

This was referenced Apr 4, 2025
Closed
Merged
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 4, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 4, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2025
@yp05327
Copy link
Contributor

yp05327 commented Apr 5, 2025

image
The g is cut by something, you can also see this issue in your screenshots.

I checked it in gitea.com, it seems that the old version does not have this issue:
image

@wxiaoguang
Copy link
Contributor Author

The g is cut by something, you can also see this issue in your screenshots.

I checked it in gitea.com, it seems that the old version does not have this issue:

A common problem, fomantic ui sometimes use line-height: 1 which doesn't work well with "overflow:hidden"

Fixed in f31b583

image

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 5, 2025 02:56
@wxiaoguang wxiaoguang merged commit ee6929d into go-gitea:main Apr 5, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-dropdown-ellipsis branch April 5, 2025 03:24
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 8, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
97a5712 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  docs: add Chinese translations for README files (go-gitea#34132)
  Keep file tree view icons consistent with icon theme (go-gitea#33921)
  Make markdown render match GitHub's behavior (go-gitea#34129)
  Remove dead code: RepoRef (go-gitea#34131)
  Correctly handle submodule view and avoid throwing 500 error (go-gitea#34121)
  Use `overflow-wrap: anywhere` to replace `word-break: break-all` (go-gitea#34126)
  Fix markdown render behaviors (go-gitea#34122)
  Refactor dropdown ellipsis (go-gitea#34123)
  Avoid creating unnecessary temporary cat file sub process (go-gitea#33942)
  Fix discord webhook 400 status code when description limit is exceeded (go-gitea#34084)
  Refactor markup render to fix various path problems (go-gitea#34114)
  [skip ci] Updated translations via Crowdin
  Fix invalid version in RPM package path (go-gitea#34112)
  also check default ssh-cert location for host (go-gitea#34099) (go-gitea#34100)
  Fix markdown frontmatter rendering (go-gitea#34102)
  Get changed files based on merge base when checking `pull_request` actions trigger (go-gitea#34106)
  Add `last_committer_date` and `last_author_date` for file contents API (go-gitea#32921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @yp05327 @lunny @GiteaBot