-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
enhancement: add additional command hints for PowerShell & CMD #33548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ing wrong signature calculations
As the command hint by SSH key verification shows That means only Linux and macOS can work properly with the origin command hint. ref: PowerShell/PowerShell#5974 (comment) And I also make the command hints collapse to minimize the section. Output ![]() ![]() |
remove additional space before '=' for lint checking
I think we could remove the "Linux & macOS" hint because it works for all POSIX standard shells. And I think we can simplify the template by removing the printf, will make some changes here, just a moment. |
Should we detect user's OS from the web browser and display the right command? |
I prefer to keep it simple, do not introduce too much JS code |
But the real output is a string which only contains letters&numbers, there is no |
So here is my output
And I also tried with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting .... Windows command line has too many quirks ....
Now I think now the generated commands should be the same as the initial ones by your first commit.
kind of magic, both of PowerShell & CMD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trust LGTM
* giteaofficial/main: Enhance routers for the Actions runner operations (go-gitea#33549) [skip ci] Updated translations via Crowdin Run yamllint with strict mode, fix issue (go-gitea#33551) Enhance routers for the Actions variable operations (go-gitea#33547) enhancement: add additional command hints for PowerShell & CMD (go-gitea#33548) Feature: Support workflow event dispatch via API (go-gitea#33545) Optimize the dashboard (go-gitea#32990) Rework suggestion backend (go-gitea#33538) Revert "Feature: Support workflow event dispatch via API (go-gitea#32059)" (go-gitea#33541)
…tea#33548) - resolving wrong signature calculations for SSH key verification Fixed go-gitea#22693 --------- Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: Giteabot <[email protected]> (cherry picked from commit e3adb68)
Fixed #22693