Skip to content

Refactor initRepoBranchTagSelector to use new init framework #33776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Mar 3, 2025

Make "initRepoBranchTagSelector" to use new init framework and fix the abused "js-branch-tag-selector" styles

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Mar 3, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 3, 2025

There are tmpl/JS errors (I have fixed them). You'd better to test your change before proposing a PR

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2025
@wxiaoguang wxiaoguang changed the title Refactor initRepoBranchTagSelector Using the New registerGlobalInitFunc Refactor initRepoBranchTagSelector to use new init framework Mar 3, 2025
@wxiaoguang wxiaoguang force-pushed the refactor-initrepobranchtagselector-with-registerglobalinitfunc branch from 52b6c69 to 0074d41 Compare March 3, 2025 09:55
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 3, 2025
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 3, 2025
@go-gitea go-gitea deleted a comment from ifox777 Mar 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 3, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@lunny lunny enabled auto-merge (squash) March 3, 2025 20:20
@lunny lunny merged commit 14be462 into go-gitea:main Mar 3, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 3, 2025
@kerwin612 kerwin612 deleted the refactor-initrepobranchtagselector-with-registerglobalinitfunc branch March 4, 2025 00:06
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 4, 2025
* giteaofficial/main:
  Adjust appearence of commit status webhook (go-gitea#33778)
  Refactor initRepoBranchTagSelector to use new init framework (go-gitea#33776)
  Refactor buttons to use new init framework (go-gitea#33774)
  Refactor markup and pdf-viewer to use new init framework (go-gitea#33772)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/templates This PR modifies the template files type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants