This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player] Fix tests #3082
Merged
[video_player] Fix tests #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecreatorormaybenot
requested review from
cyanglaz and
iskakaushik
as code owners
|
|
||
| @override | ||
| void setPlaybackSpeed(PlaybackSpeedMessage arg) { | ||
| // todo: implement as part of completing https://github.com/flutter/plugins/pull/3031 |
Contributor
Author
There was a problem hiding this comment.
I have already implemented this in the said PR, but I only want to include the tests in part 3/3 of that PR.
That was the original plan anyway 😅
ditman
approved these changes
Sep 25, 2020
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Let's merge this once STABLE/MASTER tests and the basic dart analysis pass, this should make the tree green again.
Member
|
Merging in red after verifying the tests that are currently breaking in master now pass. |
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
The previous push removed a class used for testing in the video_player package. This PR fixes tests to use the new class.
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
The previous push removed a class used for testing in the video_player package. This PR fixes tests to use the new class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should just have been part of #3031 instead, my bad!
cc @ditman
Related Issues
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Actually
This prepares a smooth transition for an upcoming PR instead of locking to an older version 👍