Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@creativecreatorormaybenot
Copy link
Contributor

Part

Part 2/3 of #3031.
This is the video_player_web part of that PR.

Checklist, full code, et al. can be found in the linked PR.


environment:
sdk: ">=2.1.0 <3.0.0"
sdk: ">=2.8.0 <3.0.0"
Copy link
Contributor Author

@creativecreatorormaybenot creativecreatorormaybenot Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am changing this here just to be consistent with the platform interface (the platform interface requires it because of pigeon v0.1.7, which annotates it on a file in preparation of null safety).

@ditman ditman self-requested a review September 25, 2020 22:33
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@ditman ditman merged commit 90c8ed4 into flutter:master Sep 26, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants