This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player_platform_interface] Playback speed #3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
creativecreatorormaybenot
changed the title
creativecreatorormaybenot
force-pushed
the
video-player-playback-speed-platform-interface
branch
3 times, most recently
from
9217602 to
cebe618
Compare
5 tasks
creativecreatorormaybenot
force-pushed
the
video-player-playback-speed-platform-interface
branch
from
a068b6d to
705ae77
Compare
creativecreatorormaybenot
requested review from
cyanglaz and
iskakaushik
as code owners
ditman
approved these changes
Sep 25, 2020
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
LGTM! Let's merge this after CI passes.
Contributor
Author
|
@ditman Great 👍 I will follow up with the web PR (after the platform interface has been published). |
Member
|
Will publish after CI passes on |
Member
|
@creativecreatorormaybenot published v2.2.0. |
Member
|
This seems to have caused breakage in Checking project video_player...
error - Classes can only extend other classes at test/video_player_test.dart:591:39 - (extends_non_class)
error - The method 'VideoPlayerApiTestSetup' isn't defined for the type 'FakeVideoPlayerPlatform' at test/video_player_test.dart:593:5 - (undefined_method)
info - The method doesn't override an inherited method at test/video_player_test.dart:605:18 - (override_on_non_overriding_member) |
Contributor
Author
|
@ditman I realized this in #3081 (comment) - really a dumb mistake by me because I did not consider the Is the way I fixed it in that PR fine or should I create an extra PR just for fixing the tree? |
Member
|
@creativecreatorormaybenot can you please separate the fix to a small PR, so we can fix the tree for the next PRs that we have to merge? |
Contributor
Author
|
@ditman One second - IDE crashed 😄 |
12 tasks
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part
Part 1/3 of #3031.
This is the
video_player_platform_interfacepart of that PR.Checklist, full code, et al. can be found in the linked PR.