Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix tests #3082

Merged
ditman merged 1 commit into from
Sep 25, 2020
Merged

[video_player] Fix tests #3082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.10.12+5

* Depend on `video_player_platform_interface` version that contains the new `TestHostVideoPlayerApi`
in order for tests to pass using the latest dependency.

## 0.10.12+4

* Keep handling deprecated Android v1 classes for backward compatibility.
Expand Down
4 changes: 2 additions & 2 deletions packages/video_player/video_player/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter
# 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 0.10.12+4
version: 0.10.12+5
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player

flutter:
Expand All @@ -20,7 +20,7 @@ flutter:

dependencies:
meta: ^1.0.5
video_player_platform_interface: ^2.1.0
video_player_platform_interface: ^2.2.0
# The design on https://flutter.dev/go/federated-plugins was to leave
# this constraint as "any". We cannot do it right now as it fails pub publish
# validation, so we set a ^ constraint.
Expand Down
9 changes: 7 additions & 2 deletions packages/video_player/video_player/test/video_player_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,9 +588,9 @@ void main() {
});
}

class FakeVideoPlayerPlatform extends VideoPlayerApiTest {
class FakeVideoPlayerPlatform extends TestHostVideoPlayerApi {
FakeVideoPlayerPlatform() {
VideoPlayerApiTestSetup(this);
TestHostVideoPlayerApi.setup(this);
}

Completer<bool> initialized = Completer<bool>();
Expand Down Expand Up @@ -657,6 +657,11 @@ class FakeVideoPlayerPlatform extends VideoPlayerApiTest {
calls.add('setVolume');
}

@override
void setPlaybackSpeed(PlaybackSpeedMessage arg) {
// todo: implement as part of completing https://github.com/flutter/plugins/pull/3031
Copy link
Contributor Author

@creativecreatorormaybenot creativecreatorormaybenot Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already implemented this in the said PR, but I only want to include the tests in part 3/3 of that PR.

That was the original plan anyway 😅

}

@override
void setMixWithOthers(MixWithOthersMessage arg) {
calls.add('setMixWithOthers');
Expand Down