Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@creativecreatorormaybenot
Copy link
Contributor

Description

Because of federated plugins, no reviews are requested automatically when opening a PR.

For example, #3032 should have probably automatically requested @iskakaushik and @cyanglaz, however, that did not happen because the paths for federated plugins are not covered at the moment.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • All existing and new tests are passing.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

@creativecreatorormaybenot creativecreatorormaybenot changed the title [all] Update CODEOWNERS for reviews [all] Update CODEOWNERS to properly request reviews Sep 15, 2020
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@cyanglaz cyanglaz merged commit 26bf10f into flutter:master Sep 16, 2020
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants