Feature/asyncify contract #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/asyncify_contract
Create Base/Async structure for ContractFunctions, ContractEvents, Contract, ContractConstructor, ContractFunction, ContractEvent, ContractCaller classes
… into feature/asyncify_contract
* asyncify eth.contract * Contract build_transaction method
… into feature/asyncify_contract
* asyncify contract.transact and contract.estimate_gas
* fill_transaction_defaults async for later use in build_transaction_for_function * build_transaction in ContractFunction * estimateGas async in Contract and docs
… into feature/asyncify_contract
* setting default contract factory in AsyncEth to AsyncContract
… into feature/asyncify_contract
… into feature/asyncify_contract
|
just realized doc changes are still needed here I will make those in the next couple days |
|
made the docs changes |
|
Looks good, thank you! I have a couple more test files to do, should be able to merge them in tomorrow. |
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Apr 23, 2022
* removed buildTransaction and estimateGas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed buildTransaction and estiamteGas since they are being deprecated in the v5 branch.