Skip to content

Feature/asyncify contract #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Apr 23, 2022

Conversation

dbfreem
Copy link
Contributor

@dbfreem dbfreem commented Apr 22, 2022

removed buildTransaction and estiamteGas since they are being deprecated in the v5 branch.

dbfreem and others added 30 commits March 3, 2022 20:50
Create Base/Async structure for ContractFunctions, ContractEvents, Contract, ContractConstructor, ContractFunction, ContractEvent, ContractCaller classes
* asyncify eth.contract

* Contract build_transaction method
* asyncify contract.transact and contract.estimate_gas
@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 22, 2022

@pacrob I removed buildTransaction and estimateGas since they are being deprecated in v5 #2438.

Also, let me know your thoughts on testing here. That is the last piece left of this async contract.

@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 22, 2022

just realized doc changes are still needed here I will make those in the next couple days

@dbfreem dbfreem marked this pull request as draft April 22, 2022 10:09
@dbfreem dbfreem marked this pull request as ready for review April 23, 2022 02:20
@dbfreem
Copy link
Contributor Author

dbfreem commented Apr 23, 2022

made the docs changes

@pacrob pacrob merged commit 54e7bb3 into ethereum:asyncify-contract Apr 23, 2022
@pacrob
Copy link
Contributor

pacrob commented Apr 23, 2022

Looks good, thank you! I have a couple more test files to do, should be able to merge them in tomorrow.

pacrob pushed a commit to pacrob/web3.py that referenced this pull request Apr 23, 2022
* removed buildTransaction and estimateGas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants