-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Feature/asyncify contract #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/asyncify contract #2404
Conversation
… into feature/asyncify_contract
… into feature/asyncify_contract
… into feature/asyncify_contract
@ChristianCoenen this is a change that should fix what you reported in #2394. Let me know what you think. @pacrob Setting the defaultContractFactory to AsyncContract in AsyncEth |
Thanks, lgtm!
Was there a reason for this like failing tests or some edge cases? Wouldn't just adding defaultContractFactory: Type[Union[AsyncContract, AsyncContractCaller]] = AsyncContract to |
@ChristianCoenen I don't know what happened but when I made the change you suggested it broke some test. To be honest I didn't look into it and just moved the methods down to AsyncEth and Eth. It was probably something simple I did. I read your message above and thought "yea that should have worked" and it did when I made the changes you suggested again this evening. So I am opening another PR to revert some of those changes I made last night and implement your suggestion. Thanks so much for looking into this! |
* setting default contract factory in AsyncEth to AsyncContract
* setting default contract factory in AsyncEth to AsyncContract
* setting default contract factory in AsyncEth to AsyncContract
More AsyncContract
Set default contract factory to AsyncContract in AsyncEth
Unfortunately, this required copy and pasting those three contract functions and the property from the BaseEth class to the Eth and AsyncEth classes