This repository was archived by the owner on Sep 5, 2024. It is now read-only.
feat(interimElement): properly handle multiple interims. #9053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
needs: manual testing
|
|
||
| // Note: This function might be called when the element already has been removed, | ||
| // in which case we won't find any matches. | ||
| if (filtered.length > 0) { |
There was a problem hiding this comment.
isn't filtered.length is enough?
There was a problem hiding this comment.
It should be. I will change it tomorrow.
|
Overall lgtm |
|
Dangerous changes. Must be manually validated (aka user testing) and needs more unit tests. |
* Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes angular#8624. References angular#8630.
devversion
force-pushed
the
feat/multiple-interims
branch
from
a693cdb to
dd959a8
Compare
devversion
removed
in progress
|
|
||
| // This hide()s only the current interim element before showing the next, new one | ||
| // NOTE: this is not reversible (e.g. interim elements are not stackable) | ||
| var hideAction = options.multiple ? $q.when(true) : $q.all(showPromises); |
There was a problem hiding this comment.
You can use $q.resolve() instead of $q.when(true)
|
Ping @ErinCoughlan for review. |
|
@ErinCoughlan @topherfangio - Ping again for review, want to push that PR a bit. |
topherfangio
approved these changes
Sep 15, 2016
devversion
removed
the
needs: manual testing
ThomasBurleson
added
needs: presubmit
and removed
needs: review
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
* feat(interimElement): properly handle multiple interims. * Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes angular#8624. References angular#8630. * When hiding wait for currenlty opening interims * Address EladBezalel's feedback * Wait for interim element for cancel as well * Address EladBezalel's feedback
|
Just adding a link to Keep support to "skipHide" with a deprecation warning #10438. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening interim elements, by rapidly clicking on the open button as an example, the toasts / interims will overlap. But those shouldn't overlap. This is against the specs.
@ThomasBurleson Nothing really changed for the components. It just fixed the issue with overlapping and opens the door of having multiple interims (this was just included into that fix)
Fixes #8624. References #9166 References #8630.