Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Closing by $mdDialog.cancel() a nested dialog closes the parent, not the current one #9638

Closed
franjuan opened this issue Sep 18, 2016 · 4 comments
Assignees

Comments

@franjuan
Copy link

franjuan commented Sep 18, 2016

Actual Behavior:

  • What is the issue? When I open a new dialog ($mdDialog.show with skipHide: true) inside another dialog, it opens correctly. But when I try to close cancelling it ($mdDialog.cancel), the dialog which is closed is the first one, the parent, the one who opens the dialog which calls cancel operation. The child dialog still remains and when canceled again it is closed then.
  • What is the expected behavior? The dialog which is expected to be closed is the child one, the one whose controller called the cancel operation.

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue:
  • Details:
  1. Open a new dialog with $mdDialog.show
  2. Open a new dialog inside the last one with $mdDialog.show (skipHide:true)
  3. Cancel the last dialog with $mdDialog.cancel

Angular Versions: *

  • Angular Version: 1.5.5
  • Angular Material Version: 1.1.1

Additional Information:

  • Browser Type: Firefox and Chrome
  • Browser Version: Chrome 53.0.2785.116 m (64-bit) and Firefox 48.0.2
  • OS: Windows 10
  • Stack Traces:
@devversion
Copy link
Member

This should be fixed after #9053

@devversion devversion self-assigned this Sep 19, 2016
@franjuan
Copy link
Author

Thanks a lot!

@devversion
Copy link
Member

devversion commented Sep 23, 2016

Should be fixed within master. Please notice that skipHide has been renamed to multiple: true.

Let me know if you still see that issue :)

@franjuan
Copy link
Author

Thank you very much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants