Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(): support multiple as a default preset method #9737

Merged
merged 1 commit into from
Oct 12, 2016

Conversation

devversion
Copy link
Member

  • Dialogs, Bottom-Sheets and Toasts have presets, which all depend on the build preset automatically.
  • Due to the new muliple property in the $$interimElement factory, developers can explicitly pass the multiple property per JSON, but not as a preset method.

@ThomasBurleson: This just creates an alias for the given option.

* Dialogs, Bottom-Sheets and Toasts have presets, which all depend on the `build` preset automatically.

* Due to the new `muliple` property in the `$$interimElement` factory, developers can explicitly pass the multiple property per JSON, but not as a preset method.
@devversion devversion added the needs: review This PR is waiting on review from the team label Oct 2, 2016
@ThomasBurleson
Copy link
Contributor

@devversion - what is the issue that this resolves ?

@devversion
Copy link
Member Author

devversion commented Oct 5, 2016

@ThomasBurleson This is a followup PR to the #9053, which just provides the "new available" option in the default preset - This is a step forward to #8630

@ThomasBurleson
Copy link
Contributor

@devversion - If we consider our planned changes to $mdCompile and use of the Component API & mdPanel, is this necessary ?

@ThomasBurleson ThomasBurleson added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed needs: review This PR is waiting on review from the team labels Oct 9, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Oct 9, 2016
@devversion
Copy link
Member Author

devversion commented Oct 9, 2016

@ThomasBurleson This does not interfere with anything of that. It just provides the alias of the multiple flag, which was not added in the original PR.

Right now you can do

$mdDialog({
  multiple: true
}

But to be consistent with all "available" options for the $$interimElement, the preset should also have a method for this

$mdDialog(
  $mdDialog
    .build()
    .multiple(true)
);

All available options should be added to that methods array.

@ThomasBurleson ThomasBurleson added needs: presubmit and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Oct 10, 2016
@kara kara added pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Oct 12, 2016
@kara kara merged commit 3387109 into angular:master Oct 12, 2016
@devversion devversion deleted the feat/interim-multiple branch October 30, 2016 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants