This repository was archived by the owner on Sep 5, 2024. It is now read-only.
interimElement: finish animation of previous element #8624
Assignees
Labels
has: Pull Request
A PR has been created to address this issue
P2: required
Issues that must be fixed.
type: bug
Comments
devversion
added a commit
to devversion/material
that referenced
this issue
Jul 16, 2016
* Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes angular#8624. References angular#8630.
devversion
added
has: Pull Request
devversion
added a commit
to devversion/material
that referenced
this issue
Sep 1, 2016
* Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes angular#8624. References angular#8630.
jelbourn
pushed a commit
that referenced
this issue
Sep 21, 2016
* feat(interimElement): properly handle multiple interims. * Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes #8624. References #8630. * When hiding wait for currenlty opening interims * Address EladBezalel's feedback * Wait for interim element for cancel as well * Address EladBezalel's feedback
Frank3K
pushed a commit
to Frank3K/material
that referenced
this issue
Oct 8, 2016
* feat(interimElement): properly handle multiple interims. * Adds support for multiple interim elements (like dialog) * When single interim (default) is enabled, then interims should hide properly (as in toasts). Fixes angular#8624. References angular#8630. * When hiding wait for currenlty opening interims * Address EladBezalel's feedback * Wait for interim element for cancel as well * Address EladBezalel's feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
The
$$interimElementfactory currently only supports singleinterimElementsat the same time.This is intentionally, but it doesn't work properly for some components.
(See Toasts overlap #4822, $mdToast increases watchers but does not remove them if multiple toasts are displayed within a digest. #5193)
This is caused by the
$$interimElement's item stack.Once a second interim element is opening, we cancel the previous interim element and show the new one after the animation has started
This is not correct, because we should wait for the animation to be finished
The text was updated successfully, but these errors were encountered: