Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Keep support to "skipHide" with a deprecation warning #10438

Open
Liz4v opened this issue Feb 23, 2017 · 2 comments
Open

Keep support to "skipHide" with a deprecation warning #10438

Liz4v opened this issue Feb 23, 2017 · 2 comments
Assignees
Labels
P5: nice to have These issues will not be fixed without community contributions.

Comments

@Liz4v
Copy link

Liz4v commented Feb 23, 2017

Actual Behavior:

  1. Upgrade build version from 1.1.1 to 1.1.3
  2. Breaking change: $mdDialog.show({skipHide: true}) stops working because it was renamed to multiple. (See dialog: skipHide not working #10076)

Expected Behavior:

  1. Upgrade build version from 1.1.1 to 1.1.3
  2. Rename should generate a deprecation warning, but keep working for the full ~1.1.1 branch forever.
@LoganLehman
Copy link

Agreed. This needs to happen so things don't break immediately.

@EladBezalel EladBezalel self-assigned this Mar 18, 2017
@EladBezalel EladBezalel added the P5: nice to have These issues will not be fixed without community contributions. label Mar 18, 2017
@arcreative
Copy link

...glad I noticed the errant behavior. This is a pretty big deal and breaks a lot of things in my app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P5: nice to have These issues will not be fixed without community contributions.
Projects
None yet
Development

No branches or pull requests

5 participants