Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

dialog: skipHide not working #10076

Closed
scriptsure opened this issue Dec 1, 2016 · 5 comments
Closed

dialog: skipHide not working #10076

scriptsure opened this issue Dec 1, 2016 · 5 comments

Comments

@scriptsure
Copy link

scriptsure commented Dec 1, 2016

Actual Behavior:

  • What is the issue? *

I HAVE UPGRADED FROM 1.1.1 TO THE MASTER BRANCH AND NOW ALL THE SKIPHIDE: TRUE NO LONGER WORK. IN OTHER WORDS THE CHILD DIALOG OPENS BUT IN THE PROCESS ALSO CLOSES THE PARENT DIALOG.

CODEPEN: http://codepen.io/scriptsure/pen/ObzxvR

  • What is the expected behavior?
    THE PARENT DIALOG SHOULD REMAIN OPEN

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue: http://codepen.io/scriptsure/pen/ObzxvR
  • Details:
    CLICK CUSTOM DIALOG BUTTON.
    THE PARENT DIALOG WILL APPEAR.
    CLICK THE CUSTOM DIALOG BUTTON AGAIN
    THE PARENT WILL CLOSE AND THE CHILD WILL OPEN

Angular Versions: *

  • Angular Version: 1.5.8
  • Angular Material Version: MASTER

Additional Information:

  • Browser Type: * CHROME
  • Browser Version: *
  • OS: * WINDOWS 8
  • Stack Traces:

Shortcut to create a new CodePen Demo.
Note: * indicates required information. Without this information, your issue may be auto-closed.

Do not modify the titles or questions. Simply add your responses to the ends of the questions.
Add more lines if needed.

@devversion
Copy link
Member

We have changed skipHide to multiple.

See Pull Request #9053

Codepen: http://codepen.io/DevVersion/pen/YpYrgy

@ThomasBurleson ThomasBurleson changed the title skipHide Bug dialog: skipHide not working Dec 2, 2016
@Liz4v
Copy link

Liz4v commented Feb 23, 2017

A deprecation warning wold be very helpful, guys.

@mgol
Copy link
Member

mgol commented Apr 13, 2017

Such a rename shouldn't happen in a patch update as it's clearly a breaking change.

@chm0815
Copy link

chm0815 commented Jul 13, 2017

this rename cost me 3 hours :(

@daryldcL
Copy link

daryldcL commented Aug 3, 2017

Yeah, me too. :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants