Correct PHP version requirements #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is (somewhat) a duplicate of #249. |
Contributor
Author
|
@paulomarg please can you merge this (and hopefully #236 too) before releasing the major version number that you will be doing following #262. That'll reduce the number of major version numbers you need to produce. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current PHP version constraint (
^8.0 || ^8.1 || ^8.2) doesn't make sense. It looks like the package is intended to support PHP versions8.0.xand8.1.xand8.2.xwith unknown status given to8.3.xand8.4.xand so on. However, the constraints used currently is equivalent to^8.0and supports all versions of8.x.x.https://jubianchi.github.io/semver-check/#/^8.0/8.1.45
WHAT is this pull request doing?
This pull request refines the supported versions to include only those that seem to be intended. When new versions are released, these can be added to the list.
Type of change
I'm marking this as a 'patch' because we're only dropping support for future versions of PHP which don't currently exist. Also, given that the most recent pull request merged dropped support for PHP 7.x, and this hasn't been tagged / released yet, this is a great time to fix this bug too.
Checklist