Fix composer supported PHP versions #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KadelaKuba
force-pushed
the
fix-composer-php-versions
branch
from
25f02e1 to
92018b8
Compare
Author
|
I've signed the CLA! |
1 similar comment
Author
|
I've signed the CLA! |
fredden
reviewed
Apr 26, 2023
| }, | ||
| "require": { | ||
| "php": "^7.4 || ^8.0 || ^8.1", | ||
| "php": "^7.4 || ~8.0 || ~8.1.0", |
Contributor
There was a problem hiding this comment.
~1.0 is equivalent to ^1.0 or 1.*, but ~1.0.0 is equivalent to 1.0.*.
Suggested change
| "php": "^7.4 || ~8.0 || ~8.1.0", | |
| "php": "^7.4 || ~8.0.0 || ~8.1.0", |
3 tasks
Contributor
|
Closing this in favor of #264 as this would otherwise require updates for the 7.4 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This project has wrong supported php versions. The ^8.1 notation in composer means that the supported PHP version is >=8.1.0 < 9.0.0-0. But this project is not ready for PHP 8.2.
WHAT is this pull request doing?
This pull request updates the supported PHP versions in composer.json.
There are three types of PHP verions supported now:
Type of change
Checklist