Support php 8.2 #262
Merged
Support php 8.2 #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
support_php_8_2
branch
from
663aa85 to
c2f59d8
Compare
lizkenyon
reviewed
Apr 25, 2023
| sessionStorage: new FileSessionStorage('/tmp/php_sessions'), | ||
| apiVersion: '2021-04', | ||
| isEmbeddedApp: true, | ||
| isPrivateApp: false, |
Contributor
There was a problem hiding this comment.
Did this get renamed to isCustomStoreApp?
Contributor
Author
There was a problem hiding this comment.
No, I think we still use isPrivateApp. We should probably rename it, but that should be its own PR.
Co-authored-by: Liz Kenyon <[email protected]>
lizkenyon
approved these changes
Apr 26, 2023
This was referenced Apr 26, 2023
6 tasks
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
PHP 7.4 has reached its EOL, so we're no longer supporting it.
WHAT is this pull request doing?
Removing support for 7.4, and making sure everything works on 8.2.
Now that we're fully on PHP 8, we can start leveraging the new language features, like named arguments, so this PR is also updating the docs in a few places to make things simpler.
Type of change
Checklist