-
Notifications
You must be signed in to change notification settings - Fork 188
Add requirement for PHP extensions to composer.json #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mb_strlen() is used on line 188 of src/Clients/Http.php
ctype_digit() is used on line 113 of src/Utils.php
hash_equals() is used on line 78 of src/Utils.php hash_hmac() is used on line 76 of src/Utils.php and in src/Auth/OAuth.php (lines 269, 294)
This reverts commit f157732.
|
LGTM! I hope we can get this merged soon |
This adds support for PHP version 7.4, to match declaration in this project.
|
Still LGTM, hopefully we can get this merged soon @paulomarg 🚀 |
|
Hi @fredden ! We have just recently added validation and normalization for composer.json to our workflow. Would you mind updating your PR to resolve the conflicts :) Looks good otherwise! |
|
@Jan0707 yes. I've resolved the merge conflicts introduced today twice now. Feel free to squash-merge this to keep the main branch clean, or I can rebase this onto the main branch if you'd prefer. |
Jan0707
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
WHY are these changes introduced?
On line 188 of
src/Clients/Http.php, the functionmb_strlen()is used. After installing this library on a new server, I got an error from PHP saying:PHP Fatal error: Uncaught Error: Call to undefined function Shopify\Clients\mb_strlen() in .../vendor/shopify/shopify-api/src/Clients/Http.php:188shopify-api-php/src/Clients/Http.php
Line 188 in 432676a
WHAT is this pull request doing?
This pull request updates the list of requirements in
composer.jsonto include thembstringextension, which is required for this library to work properly.Update: while I was completing the 'checklist' in the GitHub pull request template, I added a test to catch this problem, and found some more extensions which are required and not listed.
Type of change
Checklist