-
-
Notifications
You must be signed in to change notification settings - Fork 97
Translations update from Hosted Weblate #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #1231
Conversation
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/de/
WalkthroughGerman locale strings were revised in app/src/main/res/values-de/strings.xml. Wording, tone, and terminology were updated across backup/import, keyphrase/password, and action labels. Resource keys remain unchanged; only string values were modified. No code or control flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🧹 Nitpick comments (4)
app/src/main/res/values-de/strings.xml (4)
10-10: Plural consistency: Prefer “Sicherungen der Anmeldeinformationen”.Matches “Sicherungen aktivieren/deaktivieren” and “Sicherung erstellen”.
- <string name="credentials_backups">Sicherung von Anmeldeinformationen</string> + <string name="credentials_backups">Sicherungen der Anmeldeinformationen</string>
5-5: Keep imperative style consistent with line 6.Line 5 uses “Passwort generieren” (OK). Line 6 still reads “Generiere Passwort” (informal imperative). Suggest aligning line 6 to “Passwort generieren” for a consistent, neutral style across the UI.
95-95: Hyphenation: “CSV‑Export”.- <string name="keepass_backup">KeePass CSV Export</string> + <string name="keepass_backup">KeePass CSV-Export</string>
115-115: Hyphenation: “CSV‑Datei”.- <string name="invalid_csv">Ungültige CSV Datei</string> + <string name="invalid_csv">Ungültige CSV-Datei</string>Note: There are other unchanged instances with similar issues (e.g., “Invalid CSV Datei”) worth aligning in a follow-up pass.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
app/src/main/res/values-de/strings.xml(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests and Build Production Debug Build
🔇 Additional comments (2)
app/src/main/res/values-de/strings.xml (2)
11-11: Verify intent change: “Wiederherstellen” → “Importieren”.If this action restores from a KeyPass backup, “Wiederherstellen” is semantically more accurate. Use “Importieren” only if this screen imports from external sources (e.g., CSV from other managers).
I can align the wording once you confirm whether this flow restores a KeyPass backup or imports external data.
21-25: Tone/formality changes look good.Switch to formal address (“Sie”) reads consistently and professionally across these UI prompts.
| <string name="invalid_keyphrase">Ungültige Schlüsselphrase</string> | ||
| <string name="credentials_backups">Sicherung von Anmeldeinformationen</string> | ||
| <string name="restore_credentials">Anmeldeinformationen importieren</string> | ||
| <string name="restore_credentials_desc">Stellen Sie Ihr Passwörter aus einer Sicherung wieder her</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Grammar fix: “Ihr Passwörter” → “Ihre Passwörter”.
- <string name="restore_credentials_desc">Stellen Sie Ihr Passwörter aus einer Sicherung wieder her</string>
+ <string name="restore_credentials_desc">Stellen Sie Ihre Passwörter aus einer Sicherung wieder her</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="restore_credentials_desc">Stellen Sie Ihr Passwörter aus einer Sicherung wieder her</string> | |
| <string name="restore_credentials_desc">Stellen Sie Ihre Passwörter aus einer Sicherung wieder her</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-de/strings.xml around line 12, the German string has
a grammar mistake: change "Stellen Sie Ihr Passwörter aus einer Sicherung wieder
her" to "Stellen Sie Ihre Passwörter aus einer Sicherung wieder her" (replace
"Ihr" with "Ihre") to correct the possessive adjective agreement.
| <string name="restore_credentials">Anmeldeinformationen importieren</string> | ||
| <string name="restore_credentials_desc">Stellen Sie Ihr Passwörter aus einer Sicherung wieder her</string> | ||
| <string name="send_feedback_desc">Technische Probleme melden oder neue Funktionen vorschlagen</string> | ||
| <string name="invalid_keyphrase">Ungültiger Schlüssel</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid conflating “Passwort/Kennwort/Schlüsselwort” with backup “Passphrase” — unify terminology across backup-related strings.
Using different terms for the same concept will confuse users and complicate support. For backup encryption, “Passphrase” is the conventional German term. Recommend standardizing all backup keyphrase strings to “Passphrase”.
Apply this diff:
- <string name="invalid_keyphrase">Ungültiger Schlüssel</string>
+ <string name="invalid_keyphrase">Ungültige Passphrase</string>
@@
- <string name="backup_desc">Sicherungen werden mit einem Kennwort verschlüsselt und auf Ihrem Gerät gespeichert</string>
+ <string name="backup_desc">Sicherungen werden mit einer Passphrase verschlüsselt und auf Ihrem Gerät gespeichert</string>
@@
- <string name="custom_keyphrase">Benutzerdefiniertes Passwort</string>
+ <string name="custom_keyphrase">Benutzerdefinierte Passphrase</string>
- <string name="alert_blank_keyphrase">Bitte Passwort eingeben</string>
+ <string name="alert_blank_keyphrase">Bitte Passphrase eingeben</string>
- <string name="generate_keyphrase">Passwort generieren</string>
+ <string name="generate_keyphrase">Passphrase generieren</string>
- <string name="set_keyphrase">Passwort festlegen</string>
+ <string name="set_keyphrase">Passphrase festlegen</string>
@@
- <string name="alert_invalid_keyphrase">Bitte ein gültiges Passwort eingeben</string>
+ <string name="alert_invalid_keyphrase">Bitte eine gültige Passphrase eingeben</string>
@@
- <string name="backup_screen_desc">Sichern Sie Ihre Anmeldeinformationen, um Datenverlust zu verhindern. Backups werden mit einem Schlüsselwort verschlüsselt.</string>
+ <string name="backup_screen_desc">Sichern Sie Ihre Anmeldeinformationen, um Datenverlust zu verhindern. Backups werden mit einer Passphrase verschlüsselt.</string>Follow-up: Consider updating unchanged occurrences (e.g., copy_keypharse_msg, set_keyphrase_info, keyphrase_validate_info, etc.) in this file to the same term for full consistency.
Also applies to: 32-32, 69-73, 81-81, 131-131
🤖 Prompt for AI Agents
In app/src/main/res/values-de/strings.xml around lines 14, 32, 69-73, 81 and
131, several backup-related strings use inconsistent German terms like
"Schlüssel" or "Kennwort" for the backup keyphrase; replace those terms with the
standardized German term "Passphrase" so all backup-related strings (e.g.,
invalid_keyphrase, copy_keypharse_msg, set_keyphrase_info,
keyphrase_validate_info, etc.) consistently use "Passphrase" and update any
typos (e.g., keypharse → keyphrase) to maintain consistency across the file.
| <string name="help">Hilfe</string> | ||
| <string name="security">Sicherheit</string> | ||
| <string name="account_name">Kontobezeichnung</string> | ||
| <string name="account_name">Kontenname</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Typo: “Kontenname” → “Kontoname”.
- <string name="account_name">Kontenname</string>
+ <string name="account_name">Kontoname</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="account_name">Kontenname</string> | |
| <string name="account_name">Kontoname</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-de/strings.xml around line 39 the German string has a
typo "Kontenname"; change the value of the string resource name="account_name"
from "Kontenname" to the correct "Kontoname" and save the file so the translated
label reads correctly.
| <string name="secret_key">Geheimer Schlüssel</string> | ||
| <string name="keypass_backup">KeyPass Backup</string> | ||
| <string name="google_backup">Google Backup</string> | ||
| <string name="google_backup">Chrome/Google Passwörter export</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Grammar/readability: Use a verb phrase for export action.
- <string name="google_backup">Chrome/Google Passwörter export</string>
+ <string name="google_backup">Passwörter aus Chrome/Google exportieren</string>Alternative: “Chrome/Google‑Passwörter exportieren”.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="google_backup">Chrome/Google Passwörter export</string> | |
| <string name="google_backup">Passwörter aus Chrome/Google exportieren</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-de/strings.xml around line 91, the string value for
name="google_backup" uses a noun phrase "Chrome/Google Passwörter export" which
is grammatically awkward; replace it with a verb phrase such as
"Chrome/Google‑Passwörter exportieren" (or "Chrome/Google-Passwörter
exportieren") to improve readability and correctness.
Translations update from Hosted Weblate for KeyPass/KeyPass.
Current translation status:
Summary by CodeRabbit