Skip to content

Conversation

@weblate
Copy link
Contributor

@weblate weblate commented Jul 13, 2025

Translations update from Hosted Weblate for KeyPass/KeyPass.

It also includes following components:

Current translation status:

Weblate translation status

Summary by CodeRabbit

  • New Features

    • Added comprehensive Estonian language support for various app interface elements, including help, security, account management, password handling, biometric authentication, backup/restore, feedback, sorting, and error messages.
  • Documentation

    • Introduced an Estonian informational description highlighting key app features such as offline use, no ads, open source, backup/restore capabilities, and two-factor authentication support.

Priit Jõerüüt added 7 commits July 13, 2025 22:02
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings)

Translation: KeyPass/KeyPass
Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (3 of 3 strings)

Translation: KeyPass/Meta data
Translate-URL: https://hosted.weblate.org/projects/keypass/meta-data/et/
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 13, 2025

Walkthrough

This update introduces a comprehensive set of new Estonian language string resources to the application's UI and adds an Estonian full description metadata file for the app store. No existing resources were altered or removed; all changes involve new additions for localization and informational purposes.

Changes

File(s) Change Summary
app/src/main/res/values-et/strings.xml Added numerous new Estonian string resources for UI elements related to help, security, backup, password management, biometrics, feedback, and more. No deletions or modifications.
fastlane/metadata/android/et/full_description.txt Added new Estonian app store description file outlining app features, backup advice, and GitHub link.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant App UI
    participant Strings (Estonian)
    participant App Store Metadata

    User ->> App UI: Interacts with features (help, backup, security, etc.)
    App UI ->> Strings (Estonian): Requests localized text for UI elements
    Strings (Estonian) -->> App UI: Supplies Estonian translations
    User ->> App Store: Views app description
    App Store ->> App Store Metadata: Fetches Estonian full description
    App Store Metadata -->> User: Displays Estonian app info and warnings
Loading

Possibly related PRs

Suggested reviewers

  • yogeshpaliyal

Poem

In Estonian words, the app now sings,
With help and backup, and password things.
A store description, clear and neat,
Guides each user on their seat.
🐰✨
So hop along, explore anew—
The UI now speaks Eesti too!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
app/src/main/res/values-et/strings.xml (1)

24-24: Add space before placeholder to avoid glued output

Viimane varukoopia:%s renders without a space between the label and the date.
Either add a hard-coded space or move it inside the placeholder.

-<string name="last_backup_date">Viimane varukoopia:%s</string>
+<string name="last_backup_date">Viimane varukoopia: %s</string>
fastlane/metadata/android/et/full_description.txt (1)

5-9: Bullet list is rendered as one long paragraph in Play Console

Numbered points are separated only by line breaks; Play / F-Droid markdown collapses these, producing a wall of text.
Insert blank lines or a proper list marker ( or -) before each item to preserve readability.

-1. Rakendus ei vaja tööks võrguühendust
-2. Pole reklaame
-3. Avatud lähtekoodiga (kui tahad, siis saad lähtekoodi uurida)
-4. Salasõnade/kasutajanimede varundus ja taastamine varukoopiast
-5. Kahe faktoriga autentimise haldust (TOTP-põhine)
+
+• Rakendus ei vaja tööks võrguühendust  
+• Pole reklaame  
+• Avatud lähtekoodiga (kui tahad, siis saad lähtekoodi uurida)  
+• Salasõnade/kasutajanimede varundus ja taastamine varukoopiast  
+• Kahe faktoriga autentimise haldus (TOTP-põhine)
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb864e7 and a389abd.

📒 Files selected for processing (2)
  • app/src/main/res/values-et/strings.xml (1 hunks)
  • fastlane/metadata/android/et/full_description.txt (1 hunks)
🧰 Additional context used
🪛 LanguageTool
fastlane/metadata/android/et/full_description.txt

[uncategorized] ~5-~5: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ... 1. Rakendus ei vaja tööks võrguühendust 2. Pole reklaame 3. Avatud lähtekoodiga (ku...

(AI_DE_GGEC_UNNECESSARY_SPACE)


[uncategorized] ~6-~6: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...aja tööks võrguühendust 2. Pole reklaame 3. Avatud lähtekoodiga (kui tahad, siis saa...

(AI_DE_GGEC_UNNECESSARY_SPACE)


[uncategorized] ~7-~7: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...(kui tahad, siis saad lähtekoodi uurida) 4. Salasõnade/kasutajanimede varundus ja ta...

(AI_DE_GGEC_UNNECESSARY_SPACE)


[uncategorized] ~8-~8: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...mede varundus ja taastamine varukoopiast 5. Kahe faktoriga autentimise haldust (TOTP...

(AI_DE_GGEC_UNNECESSARY_SPACE)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Tests and Build Production Debug Build

<string name="credentials_backups_desc">Varunda salasõnad rakenduse väliselt</string>
<string name="backup_screen_desc">Andmekao vältimiseks varunda salasõnad/kasutajakontod turvaliselt. Varukoopiad on krüptitud salafraasiga.</string>
<string name="about_us_desc">Teave rakenduse arendaja kohta</string>
<string name="copy_keypharse_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Typo in key name breaks link with default locale

The resource key is spelled copy_keypharse_msg – note the transposed r and s.
If the base (en) file uses copy_keyphrase_msg, this entry will never be picked up, leading to an untranslated string at runtime.

-    <string name="copy_keypharse_msg">Märgi see salafraas üles ...
+    <string name="copy_keyphrase_msg">Märgi see salafraas üles ...
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="copy_keypharse_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string>
<string name="copy_keyphrase_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string>
🤖 Prompt for AI Agents
In app/src/main/res/values-et/strings.xml at line 126, the resource key is
misspelled as copy_keypharse_msg with the letters 'r' and 's' transposed. Rename
the key to copy_keyphrase_msg to match the base locale key exactly, ensuring the
translation is correctly linked and displayed at runtime.

Comment on lines +127 to +128
<string name="alert_black_secret_key">Palun sisesta salavõti</string>
<string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

alert_black_*alert_blank_*?

Both keys read alert_black_secret_key / alert_black_account_name.
Judging by the English originals they should probably be blank (empty), not black (colour).

Mismatch will again leave the corresponding UI text untranslated.

-    <string name="alert_black_secret_key">Palun sisesta salavõti</string>
-    <string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string>
+    <string name="alert_blank_secret_key">Palun sisesta salavõti</string>
+    <string name="alert_blank_account_name">Palun sisesta kasutajakonto nimi</string>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string name="alert_black_secret_key">Palun sisesta salavõti</string>
<string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string>
<string name="alert_blank_secret_key">Palun sisesta salavõti</string>
<string name="alert_blank_account_name">Palun sisesta kasutajakonto nimi</string>
🤖 Prompt for AI Agents
In app/src/main/res/values-et/strings.xml at lines 127 to 128, the string
resource keys use "alert_black_secret_key" and "alert_black_account_name" but
should use "alert_blank_secret_key" and "alert_blank_account_name" to match the
intended meaning of "blank" (empty) rather than "black" (color). Rename these
keys accordingly to fix the mismatch and ensure the UI text is correctly
translated.

@yogeshpaliyal yogeshpaliyal merged commit c79ec10 into yogeshpaliyal:master Jul 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants