-
-
Notifications
You must be signed in to change notification settings - Fork 96
Translations update from Hosted Weblate #1226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #1226
Conversation
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (137 of 137 strings) Translation: KeyPass/KeyPass Translate-URL: https://hosted.weblate.org/projects/keypass/keypass/et/
Currently translated at 100.0% (3 of 3 strings) Translation: KeyPass/Meta data Translate-URL: https://hosted.weblate.org/projects/keypass/meta-data/et/
WalkthroughThis update introduces a comprehensive set of new Estonian language string resources to the application's UI and adds an Estonian full description metadata file for the app store. No existing resources were altered or removed; all changes involve new additions for localization and informational purposes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App UI
participant Strings (Estonian)
participant App Store Metadata
User ->> App UI: Interacts with features (help, backup, security, etc.)
App UI ->> Strings (Estonian): Requests localized text for UI elements
Strings (Estonian) -->> App UI: Supplies Estonian translations
User ->> App Store: Views app description
App Store ->> App Store Metadata: Fetches Estonian full description
App Store Metadata -->> User: Displays Estonian app info and warnings
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
app/src/main/res/values-et/strings.xml (1)
24-24: Add space before placeholder to avoid glued output
Viimane varukoopia:%srenders without a space between the label and the date.
Either add a hard-coded space or move it inside the placeholder.-<string name="last_backup_date">Viimane varukoopia:%s</string> +<string name="last_backup_date">Viimane varukoopia: %s</string>fastlane/metadata/android/et/full_description.txt (1)
5-9: Bullet list is rendered as one long paragraph in Play ConsoleNumbered points are separated only by line breaks; Play / F-Droid markdown collapses these, producing a wall of text.
Insert blank lines or a proper list marker (•or-) before each item to preserve readability.-1. Rakendus ei vaja tööks võrguühendust -2. Pole reklaame -3. Avatud lähtekoodiga (kui tahad, siis saad lähtekoodi uurida) -4. Salasõnade/kasutajanimede varundus ja taastamine varukoopiast -5. Kahe faktoriga autentimise haldust (TOTP-põhine) + +• Rakendus ei vaja tööks võrguühendust +• Pole reklaame +• Avatud lähtekoodiga (kui tahad, siis saad lähtekoodi uurida) +• Salasõnade/kasutajanimede varundus ja taastamine varukoopiast +• Kahe faktoriga autentimise haldus (TOTP-põhine)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/src/main/res/values-et/strings.xml(1 hunks)fastlane/metadata/android/et/full_description.txt(1 hunks)
🧰 Additional context used
🪛 LanguageTool
fastlane/metadata/android/et/full_description.txt
[uncategorized] ~5-~5: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ... 1. Rakendus ei vaja tööks võrguühendust 2. Pole reklaame 3. Avatud lähtekoodiga (ku...
(AI_DE_GGEC_UNNECESSARY_SPACE)
[uncategorized] ~6-~6: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...aja tööks võrguühendust 2. Pole reklaame 3. Avatud lähtekoodiga (kui tahad, siis saa...
(AI_DE_GGEC_UNNECESSARY_SPACE)
[uncategorized] ~7-~7: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...(kui tahad, siis saad lähtekoodi uurida) 4. Salasõnade/kasutajanimede varundus ja ta...
(AI_DE_GGEC_UNNECESSARY_SPACE)
[uncategorized] ~8-~8: Das sieht falsch platziert oder unnötig aus. Überlegen Sie, es zu löschen.
Context: ...mede varundus ja taastamine varukoopiast 5. Kahe faktoriga autentimise haldust (TOTP...
(AI_DE_GGEC_UNNECESSARY_SPACE)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests and Build Production Debug Build
| <string name="credentials_backups_desc">Varunda salasõnad rakenduse väliselt</string> | ||
| <string name="backup_screen_desc">Andmekao vältimiseks varunda salasõnad/kasutajakontod turvaliselt. Varukoopiad on krüptitud salafraasiga.</string> | ||
| <string name="about_us_desc">Teave rakenduse arendaja kohta</string> | ||
| <string name="copy_keypharse_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in key name breaks link with default locale
The resource key is spelled copy_keypharse_msg – note the transposed r and s.
If the base (en) file uses copy_keyphrase_msg, this entry will never be picked up, leading to an untranslated string at runtime.
- <string name="copy_keypharse_msg">Märgi see salafraas üles ...
+ <string name="copy_keyphrase_msg">Märgi see salafraas üles ...📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="copy_keypharse_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string> | |
| <string name="copy_keyphrase_msg">Märgi see salafraas üles ja hoia turvaliselt. Teda kasutatakse varukoopiast taastamisel ja KeyPass ei näita teda enam uuesti. Kas oled ta kopeerinud või üles märkinud?</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-et/strings.xml at line 126, the resource key is
misspelled as copy_keypharse_msg with the letters 'r' and 's' transposed. Rename
the key to copy_keyphrase_msg to match the base locale key exactly, ensuring the
translation is correctly linked and displayed at runtime.
| <string name="alert_black_secret_key">Palun sisesta salavõti</string> | ||
| <string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alert_black_* → alert_blank_*?
Both keys read alert_black_secret_key / alert_black_account_name.
Judging by the English originals they should probably be blank (empty), not black (colour).
Mismatch will again leave the corresponding UI text untranslated.
- <string name="alert_black_secret_key">Palun sisesta salavõti</string>
- <string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string>
+ <string name="alert_blank_secret_key">Palun sisesta salavõti</string>
+ <string name="alert_blank_account_name">Palun sisesta kasutajakonto nimi</string>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <string name="alert_black_secret_key">Palun sisesta salavõti</string> | |
| <string name="alert_black_account_name">Palun sisesta kasutajakonto nimi</string> | |
| <string name="alert_blank_secret_key">Palun sisesta salavõti</string> | |
| <string name="alert_blank_account_name">Palun sisesta kasutajakonto nimi</string> |
🤖 Prompt for AI Agents
In app/src/main/res/values-et/strings.xml at lines 127 to 128, the string
resource keys use "alert_black_secret_key" and "alert_black_account_name" but
should use "alert_blank_secret_key" and "alert_blank_account_name" to match the
intended meaning of "blank" (empty) rather than "black" (color). Rename these
keys accordingly to fix the mismatch and ensure the UI text is correctly
translated.
Translations update from Hosted Weblate for KeyPass/KeyPass.
It also includes following components:
Current translation status:
Summary by CodeRabbit
New Features
Documentation