Skip to content

Conversation

@github-actions
Copy link

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from 2cd3f29 to 323e644 Compare February 24, 2025 10:19
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 323e644 to 71d1fcf Compare March 10, 2025 10:17
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from 40f3c4f to 28e4431 Compare March 24, 2025 10:19
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 28e4431 to 14491db Compare March 31, 2025 10:20
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from 279a12c to b0805f1 Compare April 14, 2025 10:20
@github-actions github-actions bot force-pushed the update-translations/weblate branch from b0805f1 to 7bb9c53 Compare April 21, 2025 10:19
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from 86b3f96 to 367a2bd Compare May 5, 2025 10:20
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from e573478 to 22a7818 Compare May 19, 2025 10:21
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from 8e0920e to 24c061c Compare June 2, 2025 10:22
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 24c061c to 300c9ec Compare June 9, 2025 10:21
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 300c9ec to 1459952 Compare June 16, 2025 10:22
@github-actions github-actions bot force-pushed the update-translations/weblate branch 2 times, most recently from b999379 to 4458e17 Compare June 30, 2025 10:22
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 4458e17 to 1baca18 Compare July 7, 2025 10:22
chrisbobbe and others added 10 commits July 24, 2025 18:40
Thanks Komyyy for this idea, which I took from PR zulip#1363.

Co-authored-by: Komyyy <[email protected]>
Servers can't yet start sending null without breaking clients.
Releasing this will start lowering the number of client installs
that would break, and eventually there will be few enough that the
breakage is acceptable; see discussion (same link as in comment):
  https://chat.zulip.org/#narrow/channel/378-api-design/topic/.60user_settings.2Etwenty_four_hour_time.60/near/2220696
See the doc:
  https://pub.dev/documentation/intl/latest/intl/DateFormat-class.html
> Formatting dates in the default 'en_US' format does not require
> any initialization.

(And we haven't been doing the described initialization for 'en_US'
or any other locale; it's asynchronous, and we have a better plan
for international formatting described in zulip#45, using ffi.)
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 20d2034 to 67b48b8 Compare September 1, 2025 10:21
MTtankkeo and others added 11 commits September 3, 2025 20:38
…nish

These tests scroll a long way, in order to be sure to scroll to the
end of the list.  That means they invoke overscroll.  The details of
how overscroll behaves are changing in an upstream PR:
  flutter/flutter#173849

The new behavior will take more than a single `pump` to reach the
end state where the subsequent checks behave as expected.  These
tests aren't about the overscroll behavior, so just gloss over any
wrinkles by calling `pumpAndSettle`.
Fixes zulip#1523.

Chris reported the issue, debugged, and wrote the core of the fix.
I added the test, found that the left and right insets reappeared,
debugged why, and added removeLeft and removeRight to fix those.

Co-authored-by: Chris Bobbe <[email protected]>
This will result in better organization when more tests are added for
another type of settings (IntGlobalSettings) in the following commits.
This `init` function has only one caller, `prepare` (it could
probably be inlined?); simplify by removing this param and the code
inside that was never being exercised.
Fixes: zulip#524

[chris: rebased atop some notification-test refactors in the last
few commits]

Co-authored-by: Chris Bobbe <[email protected]>
@github-actions github-actions bot force-pushed the update-translations/weblate branch from 67b48b8 to cd8bfab Compare September 8, 2025 10:20
rajveermalviya and others added 14 commits September 8, 2025 14:37
This reflects the condition that's directly encoded by this boolean.
(Through several conditionals in the rest of the function, we end up
confirming that this value is true just if the element does in fact
have two `.vlist-r` children, as the old name suggests.  But that
comes later and more indirectly.)
…t it

Mostly this moves and revises comments.  Also rename one local to
"depthStrut" to match its name in the KaTeX JS, which we also now use
in the explanatory comment.
…t doc

And leave a comment so we remember to keep this order when adding
more fields.
Like HasUserStore for data about users (added in 623bcb4), and
HasRealmStore for data about the realm, this will help make it
convenient for other substores to refer to data about channels.
This way, this substore becomes a valid home for methods that need
to refer to data about both messages and channels.

See also fab85ca, where we provided UserStore to ChannelStore.
@github-actions github-actions bot force-pushed the update-translations/weblate branch from cd8bfab to 34f56db Compare September 15, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants