Skip to content

Fix demo #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix demo #386

merged 2 commits into from
Jan 30, 2023

Conversation

@mitjap
Copy link
Collaborator

@mitjap mitjap commented Jan 30, 2023

When running demo command it was not working for me. First I did not build project as I expected that to be done automatically. Then there was error 404 because demo server could not find static files to serve (from tus-js-client).

  • yarn install && yarn demo produced error Cannot find module: <some_path>/index.js. So I added instruction to build before run.
  • yarn install && yarn build && yarn demo returned error 404.

yarn build command could also be added to package.json file

    "demo": "yarn build && yarn workspace demo start",
    "demo:gcs": "yarn build && yarn workspace demo start:gcs",
    "demo:s3": "yarn build && yarn workspace demo start:s3",

mitjap added 2 commits January 30, 2023 15:58
@mitjap
fix path to tus-js-client folder
d6f8b92
@mitjap
Fix documentation to use yarn demo:<store> command and to build bef…
a240377 
…ore run.

If build is skipped, a not very helpful message is displayed.
@mitjap mitjap requested a review from Murderlon January 30, 2023 15:18
@Murderlon Murderlon merged commit 68fb600 into tus:main Jan 30, 2023
@Murderlon
Copy link
Member

Great, thanks!

Murderlon added a commit to mitjap/tus-node-server that referenced this pull request May 16, 2023
@Murderlon
Merge branch 'main' into async-configstores
5a36abd 
* main:
  Bump typescript from 4.9.3 to 5.0.4 (tus#425)
  Bump sinon from 15.0.0 to 15.0.4 (tus#426)
  @tus/gcs-store: allow user to pass bucket instance to GCSStore (tus#388)
  Fix e2e test typecheking (tus#429)
  Update incorrect comment (tus#430)
  @tus/s3-store: add missing error code in termination extension (tus#413)
  @tus/[email protected]
  @tus/s3-store: fix uncaught exception when cancelling an upload (tus#412)
  @tus/[email protected]
  @tus/s3-store: fix uncaught exception when removing files (tus#410)
  @tus/s3-store: add termination extension (tus#401)
  @tus/[email protected]
  Bump @google-cloud/storage from 6.8.0 to 6.9.3 (tus#404)
  Bump http-cache-semantics from 4.1.0 to 4.1.1 (tus#393)
  Bump eslint-config-prettier from 8.5.0 to 8.6.0 (tus#392)
  Bump cookiejar from 2.1.3 to 2.1.4 (tus#383)
  Bump aws-sdk from 2.1269.0 to 2.1325.0 (tus#403)
  @tus/server: refactor and improve request validator (tus#402)
  Fix demo (tus#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitjap @Murderlon