Skip to content

Fix demo #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Fix demo #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f8b92
fix path to tus-js-client folder
mitjap Jan 30, 2023
a240377
Fix documentation to use `yarn demo:<store>` command and to build bef…
mitjap Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,20 +118,20 @@ The tus protocol supports optional [extensions][]. Below is a table of the suppo
Start the demo server using Local File Storage

```bash
yarn workspace demo start
yarn build && yarn demo
```

Start up the demo server using AWS S3. The environment variables `AWS_BUCKET`,
`AWS_ACCESS_KEY_ID`, `AWS_SECRET_ACCESS_KEY`, and `AWS_REGION` need to be present.

```bash
yarn workspace demo start:s3
yarn build && yarn demo:s3
```

Start up the demo server using Google Cloud Storage. A `keyfile.json` needs to be present in the root of the repository.

```bash
yarn workspace demo start:gcs
yarn build && yarn demo:gcs
```

Then navigate to the demo ([localhost:1080](http://localhost:1080)) which uses [`tus-js-client`](https://github.com/tus/tus-js-client).
Expand Down
2 changes: 1 addition & 1 deletion demo/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ const writeFile = (req, res) => {
if (!filename.startsWith('/dist/')) {
filename = '/demos/browser' + filename
}
filename = path.join(process.cwd(), '/node_modules/tus-js-client', filename)
filename = path.join(process.cwd(), '../node_modules/tus-js-client', filename)
fs.readFile(filename, 'binary', (err, file) => {
if (err) {
res.writeHead(500, {'Content-Type': 'text/plain'})
Expand Down