Fix e2e test typecheking #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murderlon
approved these changes
May 15, 2023
|
Thanks |
Murderlon
added a commit
to mitjap/tus-node-server
that referenced
this pull request
May 16, 2023
* main: Bump typescript from 4.9.3 to 5.0.4 (tus#425) Bump sinon from 15.0.0 to 15.0.4 (tus#426) @tus/gcs-store: allow user to pass bucket instance to GCSStore (tus#388) Fix e2e test typecheking (tus#429) Update incorrect comment (tus#430) @tus/s3-store: add missing error code in termination extension (tus#413) @tus/[email protected] @tus/s3-store: fix uncaught exception when cancelling an upload (tus#412) @tus/[email protected] @tus/s3-store: fix uncaught exception when removing files (tus#410) @tus/s3-store: add termination extension (tus#401) @tus/[email protected] Bump @google-cloud/storage from 6.8.0 to 6.9.3 (tus#404) Bump http-cache-semantics from 4.1.0 to 4.1.1 (tus#393) Bump eslint-config-prettier from 8.5.0 to 8.6.0 (tus#392) Bump cookiejar from 2.1.3 to 2.1.4 (tus#383) Bump aws-sdk from 2.1269.0 to 2.1325.0 (tus#403) @tus/server: refactor and improve request validator (tus#402) Fix demo (tus#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No type checking is performed on
e2e.test.tsat build or test during CI or locally.This PR enables typescript type checking at build and test step and fixes compilation error that would happen with typescript 5.