-
-
Notifications
You must be signed in to change notification settings - Fork 939
[TRI-1333] : Upgrade all packages to use Node18 and use fetch instead node-fetch #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 34809d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ericallam Please review and suggest changes, if any. Thanks. |
|
At first glance this is looking good. Will try and find time over the weekend to review but will get to it by Monday latest 👍 |
|
Pulled this down and looks like there is an issue with the pnpm-lock.yaml file as I'm getting this error when running Ignoring broken lockfile at /Users/eric/code/triggerdotdev/trigger.dev: Lockfile /Users/eric/code/triggerdotdev/trigger.dev/pnpm-lock.yaml not compatible with current pnpmCan you make sure you are using |
|
@ericallam I have updated the Please review and suggest changes, if any. Thank you. |
|
Unfortunately because of the original usage of pnpm v8, when you ran |
|
@ericallam Thanks for the suggestion. I grabbed the lock file from the main branch of my fork from which this PR branch was created and then did a |
… node-fetch (triggerdotdev#581) * [TRI-1333] : Upgrade all packages to use Node18 and use fetch instead of node-fetch * Changeset Added * Update pnpm-lock to compatible pnpm v7.18.1 * Restored pnpm-lock to the last known good point compatible with pnpm v7.18.1 * Update chilled-plants-exercise.md --------- Co-authored-by: Eric Allam <[email protected]>

Closes #525
✅ Checklist
Testing
Typechecking for the Packages folder has been done as mentioned in the ticket.
pnpm run --filter "./packages/**" typecheckEventsandDelaysjobs were run usingpnpm run events/delay. The commands executed succesfully and the jobs started listening on Port 8080.pnpm run dev triggerthat refreshed the job catalog on the Trigger Cloud dashboard.pnpm run --filter "!./apps/**" typecheckwas also run in the root to make sure the types are in-tact.Changelog
Node-Fetchimports and dependency are removed in all packages andfetchis getting used as the native function as supported by Node 18 now.