Skip to content

Conversation

@Dhoni77
Copy link

@Dhoni77 Dhoni77 commented Oct 4, 2023

Closes #198

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Changelog

Followed the steps to upgrade as per the remix docs:

  • Updated Types and removed deprecated types.
  • Modified deprecated useTransition hook to useNavigation hook.
  • Updated the Meta function to return array instead of object.
  • Remove Future Flags.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

⚠️ No Changeset found

Latest commit: 619c40c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Dhoni77
Copy link
Author

Dhoni77 commented Oct 4, 2023

cc @ericallam

Copy link
Member

@ericallam ericallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you could address the comments left above and also resolve the conflicts with the main branch so this PR can be easily squashed and merged. Additionally can you make sure that running typecheck and tests work and ideally a screencast added to the PR of the webapp working?

@Dhoni77
Copy link
Author

Dhoni77 commented Oct 7, 2023

cc @ericallam

@ericallam
Copy link
Member

Pulled this down and looks like there is an issue with the pnpm-lock.yaml file as I'm getting this error when running pnpm install:

Ignoring broken lockfile at /Users/eric/code/triggerdotdev/trigger.dev: Lockfile /Users/eric/code/triggerdotdev/trigger.dev/pnpm-lock.yaml not compatible with current pnpm

Can you make sure you are using [email protected]

@Dhoni77
Copy link
Author

Dhoni77 commented Oct 9, 2023

Hi @ericallam can you try once.
I deleted my old pnpm-lock and reinstalled the dependencies again.

@ericallam
Copy link
Member

Also ran into this same issue in another PR and left a comment just now about how to recover from this:

#581 (comment)

@Dhoni77
Copy link
Author

Dhoni77 commented Oct 10, 2023

Also ran into this same issue in another PR and left a comment just now about how to recover from this:

#581 (comment)

Followed the steps and resolved the issue👍

Copy link
Member

@ericallam ericallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following error in the console when running pnpm run dev --filter webapp:

webapp:dev: > [email protected] dev /Users/eric/code/triggerdotdev/trigger.dev/apps/webapp
webapp:dev: > cross-env PORT=3030 remix dev
webapp:dev: 
webapp:dev: 
webapp:dev:  💿  remix dev
webapp:dev: 
webapp:dev: [info] building...
webapp:dev: ✘ [ERROR] No matching export in "../../node_modules/.pnpm/@[email protected]_o4scbtliisanygemawej7x2d6i/node_modules/@remix-run/react/dist/esm/index.js" for import "useTransition"
webapp:dev: 
webapp:dev:     ../../node_modules/.pnpm/[email protected]_3g4awgkzsdylkd4ankfzozrqee/node_modules/remix-utils/browser/react/use-global-pending-state.js:1:9:
webapp:dev:       1 │ import { useTransition, useFetchers } from "@remix-run/react";
webapp:dev:         ╵          ~~~~~~~~~~~~~
webapp:dev: 
webapp:dev: 

@ericallam
Copy link
Member

Going to close this now as this PR is quite out of date and the requested change from 2 weeks ago hasn't been addressed. I appreciate the hard work on this PR though and appreciate that it wasn't the easiest one to get over the line as it touched on many different parts of the app.

@ericallam ericallam closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-703] Chore: update webapp to Remix 2.0.1

2 participants