-
-
Notifications
You must be signed in to change notification settings - Fork 940
chore: update webapp to Remix 2.0.1 #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
cc @ericallam |
ericallam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great if you could address the comments left above and also resolve the conflicts with the main branch so this PR can be easily squashed and merged. Additionally can you make sure that running typecheck and tests work and ideally a screencast added to the PR of the webapp working?
|
cc @ericallam |
|
Pulled this down and looks like there is an issue with the pnpm-lock.yaml file as I'm getting this error when running Ignoring broken lockfile at /Users/eric/code/triggerdotdev/trigger.dev: Lockfile /Users/eric/code/triggerdotdev/trigger.dev/pnpm-lock.yaml not compatible with current pnpmCan you make sure you are using |
|
Hi @ericallam can you try once. |
|
Also ran into this same issue in another PR and left a comment just now about how to recover from this: |
Followed the steps and resolved the issue👍 |
ericallam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting the following error in the console when running pnpm run dev --filter webapp:
webapp:dev: > [email protected] dev /Users/eric/code/triggerdotdev/trigger.dev/apps/webapp
webapp:dev: > cross-env PORT=3030 remix dev
webapp:dev:
webapp:dev:
webapp:dev: 💿 remix dev
webapp:dev:
webapp:dev: [info] building...
webapp:dev: ✘ [ERROR] No matching export in "../../node_modules/.pnpm/@[email protected]_o4scbtliisanygemawej7x2d6i/node_modules/@remix-run/react/dist/esm/index.js" for import "useTransition"
webapp:dev:
webapp:dev: ../../node_modules/.pnpm/[email protected]_3g4awgkzsdylkd4ankfzozrqee/node_modules/remix-utils/browser/react/use-global-pending-state.js:1:9:
webapp:dev: 1 │ import { useTransition, useFetchers } from "@remix-run/react";
webapp:dev: ╵ ~~~~~~~~~~~~~
webapp:dev:
webapp:dev:
|
Going to close this now as this PR is quite out of date and the requested change from 2 weeks ago hasn't been addressed. I appreciate the hard work on this PR though and appreciate that it wasn't the easiest one to get over the line as it touched on many different parts of the app. |
Closes #198
✅ Checklist
Changelog
Followed the steps to upgrade as per the remix docs: