Skip to content

Conversation

@arjunindia
Copy link
Contributor

Closes #555

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Created new stories for UIs and toasts

Changelog

  • Removes react-hot-toast based Toast
  • Adds Sonner based toast

Screenshots

image

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

⚠️ No Changeset found

Latest commit: f54a9ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam
Copy link
Member

I've recorded a video of some issues with this PR. As you can see in the video the toasts aren't right-aligned against the bottom of the window. They are also transparent and don't work very well when there are multiple toasts:

CleanShot.2023-10-06.at.17.01.33.mp4

@arjunindia
Copy link
Contributor Author

@ericallam can you check the latest revision?

@ericallam
Copy link
Member

Will do! In the meantime can you make a similar screencast as mine so I can visually inspect the changes?

@arjunindia
Copy link
Contributor Author

chrome_4h9KdbV2Uw.mp4

Here you go

@ericallam
Copy link
Member

Pulled this down and looks like there is an issue with the pnpm-lock.yaml file as I'm getting this error when running pnpm install:

Ignoring broken lockfile at /Users/eric/code/triggerdotdev/trigger.dev: Lockfile /Users/eric/code/triggerdotdev/trigger.dev/pnpm-lock.yaml not compatible with current pnpm

Can you make sure you are using [email protected]

@ericallam
Copy link
Member

Also ran into this same issue in another PR and left a comment just now about how to recover from this:

#581 (comment)

@arjunindia
Copy link
Contributor Author

I seem to have messed up :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1364] feat: Switch to Sonner toasts

2 participants