Skip to content

Conversation

@arjunindia
Copy link
Contributor

@arjunindia arjunindia commented Oct 10, 2023

Closes #555
Fixes #559

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Created new stories for UIs and toasts

Changelog

  • Removes react-hot-toast based Toast
  • Adds Sonner based toast

Screenshots

chrome_4h9KdbV2Uw.mp4

💯

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

⚠️ No Changeset found

Latest commit: 5eb072c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@arjunindia
Copy link
Contributor Author

I have decided to create a new PR considering it's easier to do this than fix the other branch :(
@ericallam

@ericallam ericallam merged commit 498f56d into triggerdotdev:main Oct 11, 2023
@arjunindia arjunindia deleted the sonner-impl branch October 11, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1364] feat: Switch to Sonner toasts

2 participants