[5.9][Macros] Allow extension macros to suppress conformances that are stated in the original source.
#67083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConformanceMacro now refines ExtensionMacro, so these roles can share the same expansion request. (cherry picked from commit c3e214c)
(cherry picked from commit e44c11f)
…eady stated in the original source. If an extension macro can introduce protocol conformances, macro expansion will check which of those protocols already have a stated conformance in the original source. The protocols that don't will be passed as arguments to extension macro expansion, indicating to the macro that it should only add conformances to those protocols. (cherry picked from commit 0bd898e)
…cro. (cherry picked from commit 74c9bfb)
…onformances:' list of an attached extension macro attribute. (cherry picked from commit 680c0b2)
(cherry picked from commit 67b30a4)
|
@swift-ci please test |
DougGregor
approved these changes
Jul 3, 2023
(cherry picked from commit fdb42fe)
I had to disable typo correction in one test case to get it to pass without diagnosing a cycle as a result of Sendable checking. But that's OK, because: - Sendable checking is prone to request cycles and needs to be redesigned - Typo correction is turned off in production (cherry picked from commit 89ad597)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extensionmacros to suppress conformances that are already stated in the original source code. This change also implementsconformancemacros in terms ofextensionmacros, so existingconformancemacros have an easier migration path to the newer design.extensionmacros to suppress conformances that are stated in the original source. #67070, Sema: Use getAllMembers() from collectVisibleMemberDecls() #67005