Sema: Use getAllMembers() from collectVisibleMemberDecls() #67005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
hborla,
xedin,
ahoppen,
bnbarham,
rintaro and
AnthonyLatsis
as code owners
slavapestov
force-pushed
the
lookup-visible-members-cleanup
branch
from
58e6a61 to
62a1133
Compare
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
lookup-visible-members-cleanup
branch
from
62a1133 to
dea7f7c
Compare
|
@swift-ci Please smoke test |
| @@ -1941,7 +1941,6 @@ SwiftDeclCollector::constructConformanceNode(ProtocolConformance *Conform) { | |||
| Conform->forEachTypeWitness( | |||
| [&](AssociatedTypeDecl *assoc, Type ty, TypeDecl *typeDecl) -> bool { | |||
There was a problem hiding this comment.
Should lambda type annotations be removed as well since it doesn't return bool anymore? Here and other places as well =]
Suggested change
| [&](AssociatedTypeDecl *assoc, Type ty, TypeDecl *typeDecl) -> bool { | |
| [&](AssociatedTypeDecl *assoc, Type ty, TypeDecl *typeDecl) { |
There was a problem hiding this comment.
Oops, no idea why that didn't cause a compile error. Thanks!
slavapestov
force-pushed
the
lookup-visible-members-cleanup
branch
from
dea7f7c to
d1fca44
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
I had to disable typo correction in one test case to get it to pass without diagnosing a cycle as a result of Sendable checking. But that's OK, because: - Sendable checking is prone to request cycles and needs to be redesigned - Typo correction is turned off in production
slavapestov
force-pushed
the
lookup-visible-members-cleanup
branch
from
d1fca44 to
89ad597
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.