[Macros] Allow extension macros to suppress conformances that are stated in the original source.
#67070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConformanceMacro now refines ExtensionMacro, so these roles can share the same expansion request.
…eady stated in the original source. If an extension macro can introduce protocol conformances, macro expansion will check which of those protocols already have a stated conformance in the original source. The protocols that don't will be passed as arguments to extension macro expansion, indicating to the macro that it should only add conformances to those protocols.
hborla
force-pushed
the
refine-extension-macros
branch
from
da52316 to
0bd898e
Compare
hborla
requested review from
AnthonyLatsis,
slavapestov,
xedin,
ahoppen,
bnbarham,
zoecarver and
CodaFi
as code owners
hborla
requested review from
rintaro
and removed request for
xedin,
CodaFi,
zoecarver and
AnthonyLatsis
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
…onformances:' list of an attached extension macro attribute.
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an extension macro can introduce protocol conformances, macro expansion will check which of those protocols already have a stated conformance in the original source. The protocols that don't will be passed as arguments to extension macro expansion, indicating to the macro that it should only add conformances to those protocols.
Resolves: rdar://111464321