Migrate the remaining completion kinds to solver-based + rework type-checking of string interpolations #63717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
4 times, most recently
from
41a2e94 to
3218a64
Compare
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
3 times, most recently
from
e7ed1dc to
1c41554
Compare
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
4 times, most recently
from
f185bed to
40fba5f
Compare
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please SourceKit stress test |
This was referenced Mar 15, 2023
[IDE] Ignore score kinds that represent implicit conversions when solving for code completion
#63855
Closed
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
2 times, most recently
from
530e94e to
80dfd5b
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
from
80dfd5b to
d735deb
Compare
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test macOS |
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
from
d735deb to
c0feec5
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
1 similar comment
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test macOS |
…`applyResultBuilderBodyTransform` when solving for code completion
…tance member reference
ahoppen
force-pushed
the
ahoppen/remaining-solver-based
branch
from
17d7c0f to
597c0dc
Compare
ahoppen
changed the title
ahoppen
requested review from
bnbarham,
rintaro,
hamishknight,
hborla,
slavapestov,
xedin,
tshortli,
CodaFi and
DougGregor
as code owners
|
@swift-ci Please test |
|
@swift-ci Please SourceKit stress test |
This was referenced Jul 12, 2023
Open
Closed
ahoppen
added a commit
to ahoppen/swift-source-compat-suite
that referenced
this pull request
Jul 12, 2023
Update after swiftlang/swift#63717 has been merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the remaining code completion kinds to solver-based. It also includes #61746 because migrating the remaining code completion kinds and that PR depend on each other.
The PR is still WIP and I’m trying to split some things off to make this PR reviewable.
rdar://73282163